[
https://issues.apache.org/jira/browse/HTRACE-221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14648056#comment-14648056
]
Colin Patrick McCabe commented on HTRACE-221:
---------------------------------------------
bq. Generally, +1
Thanks.
bq. trailing "/" necessary in the default conf dir? I see that the
config_test.go file doesn't use them
No. This code adds a trailing slash anyway, so the user doesn't need to add
one.
{code}
path := fmt.Sprintf("%s%c%s", paths[p], os.PathSeparator, cnfName)
{code}
If there's two slashes, they are condensed to one by the OS (//foo is equal to
/foo)
Committed to 4.0
> htraced: search /etc/htraced/conf for the htraced configuration by default
> --------------------------------------------------------------------------
>
> Key: HTRACE-221
> URL: https://issues.apache.org/jira/browse/HTRACE-221
> Project: HTrace
> Issue Type: Improvement
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Fix For: 4.0
>
> Attachments: HTRACE-221.001.patch
>
>
> Currently, the configuration file location must be specified by setting the
> {{HTRACED_CONF_DIR}} environment variable. Although we should continue to
> honor this environment variable if it is set, we should also default to
> looking in /etc/htraced/conf if the environment variable is not set.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
