[ 
https://issues.apache.org/jira/browse/HTRACE-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14735914#comment-14735914
 ] 

Colin Patrick McCabe commented on HTRACE-233:
---------------------------------------------

Thanks, [~clehene].

> htrace-zipkin should explicitly include slf4j-api to avoid 
> ClassNotFoundException
> ---------------------------------------------------------------------------------
>
>                 Key: HTRACE-233
>                 URL: https://issues.apache.org/jira/browse/HTRACE-233
>             Project: HTrace
>          Issue Type: Bug
>    Affects Versions: master, 4.0
>            Reporter: Cosmin Lehene
>            Assignee: Cosmin Lehene
>            Priority: Blocker
>             Fix For: 4.0
>
>         Attachments: HTRACE-233-addendum.patch, HTRACE-233.patch
>
>
> {code}
>   at com.intellij.rt.execution.application.AppMain.main(AppMain.java:140)
> Caused by: java.lang.NoClassDefFoundError: 
> org/apache/htrace/slf4j/LoggerFactory
>   at 
> org.apache.htrace.thrift.transport.TIOStreamTransport.<clinit>(TIOStreamTransport.java:38)
>   at 
> org.apache.htrace.impl.ZipkinSpanReceiver$WriteSpanRunnable.<init>(ZipkinSpanReceiver.java:214)
>   at 
> org.apache.htrace.impl.ZipkinSpanReceiver.configure(ZipkinSpanReceiver.java:178)
>   at 
> org.apache.htrace.impl.ZipkinSpanReceiver.<init>(ZipkinSpanReceiver.java:155)
>   ... 36 more
> Caused by: java.lang.ClassNotFoundException: 
> org.apache.htrace.slf4j.LoggerFactory
>   at java.net.URLClassLoader$1.run(URLClassLoader.java:372)
>   at java.net.URLClassLoader$1.run(URLClassLoader.java:361)
> {code}
> Looking in the jar I can only see the following classes
> {code}
> org/apache/htrace/slf4j/impl/NOPLoggerFactory.class
> org/apache/htrace/slf4j/impl/StaticLoggerBinder.class
> org/apache/htrace/slf4j/impl/StaticMarkerBinder.class
> org/apache/htrace/slf4j/impl/StaticMDCBinder.class
> {code}
> {{LoggerFactory}} is in {{slf4j-api}} which is not included explicitly and 
> not picked up during relocation.
> I'll send a patch



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to