[ 
https://issues.apache.org/jira/browse/HTRACE-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14902933#comment-14902933
 ] 

Hudson commented on HTRACE-260:
-------------------------------

SUCCESS: Integrated in HTrace-Master #121 (See 
[https://builds.apache.org/job/HTrace-Master/121/])
HTRACE-260. htrace-zipkin should not set the obsolete duration field in thrift 
(Adrian Cole via Colin P. McCabe) (cmccabe: rev 
c8e8cb9a16d1652c7cc3b06ffbab8f1cf2309331)
* htrace-zipkin/src/main/thrift/zipkinCore.thrift
* htrace-zipkin/src/main/java/com/twitter/zipkin/gen/zipkinCoreConstants.java
* htrace-zipkin/src/main/java/com/twitter/zipkin/gen/Annotation.java
* 
htrace-zipkin/src/main/java/org/apache/htrace/zipkin/HTraceToZipkinConverter.java


> htrace-zipkin should not set the obsolete duration field in thrift
> ------------------------------------------------------------------
>
>                 Key: HTRACE-260
>                 URL: https://issues.apache.org/jira/browse/HTRACE-260
>             Project: HTrace
>          Issue Type: Improvement
>          Components: zipkin
>    Affects Versions: 3.1.0
>            Reporter: Adrian Cole
>            Assignee: Adrian Cole
>            Priority: Minor
>             Fix For: 4.1
>
>         Attachments: HTRACE-260.patch
>
>
> Zipkin has recently dropped the Annotation.duration field, as well added new 
> constants. This implicitly this fixes incorrect use of the obsolete field: 
> HTrace always set duration to 1 microsecond.
> See https://github.com/openzipkin/zipkin/pull/717



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to