[
https://issues.apache.org/jira/browse/HTRACE-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934753#comment-14934753
]
Colin Patrick McCabe commented on HTRACE-269:
---------------------------------------------
Yeah, you're right, we don't want it to be static. It could be an instance
method. The important things to keep in mind here are that:
1. The HTraceConfiguration is not necessarily backed by a map. In fact it's
almost always backed by a Hadoop Configuration at the moment, which is not a
simple map.
2. It's best to pull all the configuration values you want out of the
HTraceConfiguration at the beginning and then leave it alone after that. This
is because Hadoop's Configuration is quite slow at accessing elements.
I don't think Hadoop's {{Configuration#getValByRegex}} is a good example of
what to do... that method has been fingered as being quite slow.
If this is something just used by Zipkin, it might be better to keep it in
htrace-zipkin for now.
> HTraceConfiguration support to get the map of configurations
> ------------------------------------------------------------
>
> Key: HTRACE-269
> URL: https://issues.apache.org/jira/browse/HTRACE-269
> Project: HTrace
> Issue Type: Wish
> Components: core
> Reporter: Cosmin Lehene
> Fix For: 4.1
>
>
> This would allow us to get all configuration prefixed by something and pass
> them along into an implementation.
> For example I'd like to take all `zipkin.kafka.*` and pass them to the Kafka
> config.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
