[
https://issues.apache.org/jira/browse/HTRACE-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15056897#comment-15056897
]
Colin Patrick McCabe commented on HTRACE-329:
---------------------------------------------
bq. Sorry. What does \[multi-character labels in every other place\] refer to?
For example, in the ServerVersion API, you get back a JSON like this:
{code}
{"ReleaseVersion":"foo","GitVersion": "bar"}
{code}
bq. Your reluctance to change Colin Patrick McCabe is some notion of possible
performance lost (if noticeable at all, it'd be in the low single digits and
one day we'll encode and compress this away anyways?) or stored size of traces
(10-15% more at the most in an era of big disk and again, we'll encode and/or
compress the difference away)?
The biggest performance issue we have right now is network bandwidth, and long
labels would certainly hurt there. I have to think about this more.
> JSON labels are opaque and so confound
> --------------------------------------
>
> Key: HTRACE-329
> URL: https://issues.apache.org/jira/browse/HTRACE-329
> Project: HTrace
> Issue Type: Improvement
> Reporter: stack
>
> Debugging, I get this in the log:
> {code}
> 2015-12-09 21:56:21,293 ERROR [localhost:61345.activeMasterManager]
> core.Tracer: Can't close TraceScope for
> {"a":"b45638d30b8c6e1dbdc001c6e7f1dd8f","b":1449726980426,"d":"get","r":"hconnection-0x6a38397","p":["b45638d30b8c6e1dbd33cf6dc5ce5206"]}
> because it is not the current TraceScope in thread
> localhost:61345.activeMasterManager
> {code}
> I could go consult a dictionary if such a thing existed on the htrace website
> (currently it does not) or go read up on some source code... but this is JSON
> so a.) perf is not a consideration so why bother shortening the labels in the
> name of 'perf' benefits and b.) JSON is ".. easy for humans to read and
> write." (second sentence on the website) yet here were are frustrating the
> first half of this sentence.
> Suggest more readable labels.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
