[
https://issues.apache.org/jira/browse/HTRACE-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15221830#comment-15221830
]
Masatake Iwasaki commented on HTRACE-351:
-----------------------------------------
The patch looks good. Just some formatting nits.
{code}
22 import java.lang.System;
{code}
This looks like redundant import.
{code}
69 for (String prefix: prefixes) {
{code}
{{prefix}} should be followed by whitespace.
+1 if these are addressed. Thanks, [~cmccabe].
> Add JavaPropertyConfiguration
> -----------------------------
>
> Key: HTRACE-351
> URL: https://issues.apache.org/jira/browse/HTRACE-351
> Project: HTrace
> Issue Type: New Feature
> Components: core
> Affects Versions: 4.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HTRACE-351.001.patch
>
>
> Add {{JavaPropertyConfiguration}}. This class reads configuration properties
> from the System configuration space. It can serve as an example of how to
> write an {{HTraceConfiguration}} class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
