[ 
https://issues.apache.org/jira/browse/HTRACE-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15293857#comment-15293857
 ] 

Colin Patrick McCabe commented on HTRACE-375:
---------------------------------------------

I thought this created the file if it didn't exist.  I have to look into this

> LocalFileSpanReceiver should create file if local.file.span.receiver.path 
> points to directory
> ---------------------------------------------------------------------------------------------
>
>                 Key: HTRACE-375
>                 URL: https://issues.apache.org/jira/browse/HTRACE-375
>             Project: HTrace
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 4.1
>            Reporter: Lewis John McGibbney
>            Assignee: Lewis John McGibbney
>
> Right now the property local.file.span.receiver.path actually requires a file 
> on disk to be present in order for spans to be written there once the span 
> buffer is full.
> Either
>  * the property should be changed to local.file.span.receiver.file.path 
> indicating that an actual FILE at a patch is required, or
>  * alternatively (probably my preferred option) if a path is given e.g. 
> /data/htrace/spans, then the file htrace.log is created and spans are written 
> there. Just like log4j does with the daily rolling file appender, after 
> 24hrs, the file will be moved to a timestamped file and a new htrace.log will 
> be created and written to.
> What do you all think?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to