javeme commented on code in PR #252:
URL:
https://github.com/apache/incubator-hugegraph-computer/pull/252#discussion_r1215321710
##########
computer-core/src/main/java/org/apache/hugegraph/computer/core/bsp/BspBase.java:
##########
@@ -42,6 +44,22 @@ public BspBase(Config config) {
this.config = config;
this.jobId = config.get(ComputerOptions.JOB_ID);
+ String inputSourceType = config.get(ComputerOptions.INPUT_SOURCE_TYPE);
Review Comment:
can we just add an option JOB_NAMESPACE?
then we set `$JOB_NAMESPACE/$JOB_ID` to `bspClient.init()`.
I think it may be too long to concat the HUGEGRAPH_URL and
HUGEGRAPH_GRAPH_NAME, if the HUGEGRAPH_URL is changed, theJOB_NAMESPACE can
also be updated at the same time.
##########
computer-core/src/main/java/org/apache/hugegraph/computer/core/bsp/BspBase.java:
##########
@@ -123,8 +141,9 @@ public final long logInterval() {
*/
protected String constructPath(BspEvent event, Object... paths) {
StringBuilder sb = new StringBuilder();
- // TODO: replace event.code() with event.name()
- sb.append(event.name());
+ if (event != null) {
+ sb.append(event.name());
Review Comment:
keep the TODP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
