imbajin commented on code in PR #478:
URL:
https://github.com/apache/incubator-hugegraph-toolchain/pull/478#discussion_r1226299070
##########
hugegraph-tools/pom.xml:
##########
@@ -38,25 +38,9 @@
<assembly.dir>${project.basedir}/assembly</assembly.dir>
<assembly.descriptor.dir>${assembly.dir}/descriptor</assembly.descriptor.dir>
<shell-executable>bash</shell-executable>
- <junit.version>4.12</junit.version>
<maven.build.timestamp.format>yyyy-MM-dd
HH:mm:ssZ</maven.build.timestamp.format>
- <hugegraph-client-version>1.0.0</hugegraph-client-version>
- <jcommand-version>1.72</jcommand-version>
- <hadoop-version>3.1.1</hadoop-version>
- <guava.version>25.1-jre</guava.version>
</properties>
- <dependencyManagement>
- <dependencies>
- <dependency>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <version>${junit.version}</version>
- <scope>test</scope>
- </dependency>
- </dependencies>
- </dependencyManagement>
-
Review Comment:
nice catch
##########
pom.xml:
##########
@@ -118,32 +119,199 @@
<docker.hub>hugegraph</docker.hub>
<docker.repo>${project.name}</docker.repo>
<docker.tag>${project.version}</docker.tag>
+ <hugegraph.common.version>1.0.0</hugegraph.common.version>
+ <hive.version>3.1.3</hive.version>
<hbase.version>2.2.3</hbase.version>
+ <hadoop.version>3.3.1</hadoop.version>
+ <zookeeper.version>3.6.2</zookeeper.version>
+ <jersey.version>3.0.3</jersey.version>
+ <junit.version>4.12</junit.version>
+ <mockito.version>2.8.47</mockito.version>
+ <lombok.version>1.18.8</lombok.version>
+ <commons.io.version>2.8.0</commons.io.version>
+ <commons.lang3.version>3.9</commons.lang3.version>
+ <commons.compress.version>1.21</commons.compress.version>
+ <commons.fileupload.version>1.5</commons.fileupload.version>
+ <commons.codec.version>1.15</commons.codec.version>
+ <commons.cli.version>1.3.1</commons.cli.version>
+ <commons.text.version>1.9</commons.text.version>
+ <commons.net.version>3.6</commons.net.version>
+ <commons.math3.version>3.4.1</commons.math3.version>
+ <commons.logging.version>1.1.3</commons.logging.version>
+ <guava.version>30.0-jre</guava.version>
+ <lz4.version>1.4.0</lz4.version>
+ <jcommand-version>1.72</jcommand-version>
+ <jackson.version>2.12.3</jackson.version>
+ <log4j2.version>2.18.0</log4j2.version>
+ <dropwizard.metics.version>4.2.0</dropwizard.metics.version>
+ <netty.version>4.1.68.Final</netty.version>
+ <gson.version>2.8.5</gson.version>
</properties>
- <dependencies>
- <!--TODO: enhance it later to avoid conflicts now -->
-<!-- <dependency>-->
-<!-- <groupId>commons-io</groupId>-->
-<!-- <artifactId>commons-io</artifactId>-->
-<!-- <version>2.7</version>-->
-<!-- </dependency>-->
-<!-- <dependency>-->
-<!-- <groupId>org.apache.commons</groupId>-->
-<!-- <artifactId>commons-lang3</artifactId>-->
-<!-- <version>3.9</version>-->
-<!-- </dependency>-->
-<!-- <dependency>-->
-<!-- <groupId>com.google.guava</groupId>-->
-<!-- <artifactId>guava</artifactId>-->
-<!-- <version>29.0-jre</version>-->
-<!-- </dependency>-->
-<!-- <dependency>-->
-<!-- <groupId>org.apache.commons</groupId>-->
-<!-- <artifactId>commons-compress</artifactId>-->
-<!-- <version>1.21</version>-->
-<!-- </dependency>-->
- </dependencies>
+ <dependencyManagement>
Review Comment:
Good, and add a short comment before DM label: submodules will not inherit
the dependencies unless they address it
##########
pom.xml:
##########
@@ -118,32 +119,199 @@
<docker.hub>hugegraph</docker.hub>
<docker.repo>${project.name}</docker.repo>
<docker.tag>${project.version}</docker.tag>
+ <hugegraph.common.version>1.0.0</hugegraph.common.version>
+ <hive.version>3.1.3</hive.version>
<hbase.version>2.2.3</hbase.version>
+ <hadoop.version>3.3.1</hadoop.version>
+ <zookeeper.version>3.6.2</zookeeper.version>
+ <jersey.version>3.0.3</jersey.version>
+ <junit.version>4.12</junit.version>
+ <mockito.version>2.8.47</mockito.version>
+ <lombok.version>1.18.8</lombok.version>
+ <commons.io.version>2.8.0</commons.io.version>
+ <commons.lang3.version>3.9</commons.lang3.version>
+ <commons.compress.version>1.21</commons.compress.version>
+ <commons.fileupload.version>1.5</commons.fileupload.version>
+ <commons.codec.version>1.15</commons.codec.version>
+ <commons.cli.version>1.3.1</commons.cli.version>
+ <commons.text.version>1.9</commons.text.version>
+ <commons.net.version>3.6</commons.net.version>
+ <commons.math3.version>3.4.1</commons.math3.version>
+ <commons.logging.version>1.1.3</commons.logging.version>
+ <guava.version>30.0-jre</guava.version>
+ <lz4.version>1.4.0</lz4.version>
+ <jcommand-version>1.72</jcommand-version>
+ <jackson.version>2.12.3</jackson.version>
Review Comment:
and be careful, the jackson version may influence or conflicts in some cases
(like in `spark/flink` env, if we change the default version in loader, it's
better to test it later, add a `WARN` comment for it ⚠️ )
##########
pom.xml:
##########
@@ -47,43 +47,44 @@
</licenses>
<developers>
- <developer>
- <id>Apache Hugegraph(Incubating)</id>
- <email>[email protected]</email>
- <url>https://hugegraph.apache.org/</url>
- </developer>
+ <developer>
+ <id>Apache Hugegraph(Incubating)</id>
+ <email>[email protected]</email>
+ <url>https://hugegraph.apache.org/</url>
+ </developer>
</developers>
<mailingLists>
- <mailingList>
- <name>Developer List</name>
- <subscribe>[email protected]</subscribe>
- <unsubscribe>[email protected]</unsubscribe>
- <post>[email protected]</post>
- </mailingList>
- <mailingList>
- <name>Commits List</name>
- <subscribe>[email protected]</subscribe>
- <unsubscribe>[email protected]</unsubscribe>
- <post>[email protected]</post>
- </mailingList>
- <mailingList>
- <name>Issues List</name>
- <subscribe>[email protected]</subscribe>
- <unsubscribe>[email protected]</unsubscribe>
- <post>[email protected]</post>
- </mailingList>
+ <mailingList>
+ <name>Developer List</name>
+ <subscribe>[email protected]</subscribe>
+ <unsubscribe>[email protected]</unsubscribe>
+ <post>[email protected]</post>
+ </mailingList>
+ <mailingList>
+ <name>Commits List</name>
+ <subscribe>[email protected]</subscribe>
+ <unsubscribe>[email protected]</unsubscribe>
+ <post>[email protected]</post>
+ </mailingList>
+ <mailingList>
+ <name>Issues List</name>
+ <subscribe>[email protected]</subscribe>
+ <unsubscribe>[email protected]</unsubscribe>
+ <post>[email protected]</post>
+ </mailingList>
</mailingLists>
<scm>
<url>https://github.com/apache/hugegraph-toolchain</url>
<connection>scm:git:https://github.com/apache/hugegraph-toolchain.git</connection>
-
<developerConnection>scm:git:https://github.com/apache/hugegraph-toolchain.git</developerConnection>
+
<developerConnection>scm:git:https://github.com/apache/hugegraph-toolchain.git
+ </developerConnection>
Review Comment:
```suggestion
<developerConnection>
scm:git:https://github.com/apache/hugegraph-toolchain.git
</developerConnection>
```
##########
hugegraph-loader/pom.xml:
##########
@@ -27,31 +27,37 @@
</parent>
<artifactId>hugegraph-loader</artifactId>
-<!-- <packaging>jar</packaging>-->
+ <packaging>jar</packaging>
<name>${project.artifactId}</name>
<url>https://github.com/apache/incubator-hugegraph-toolchain/tree/master/hugegraph-loader</url>
<description>
- hugegraph-loader is a customizable command line utility for loading
small to medium size graph datasets
+ hugegraph-loader is a customizable command line utility for loading
small to medium size
+ graph datasets
into the HugeGraph database from multiple data sources with various
input formats.
Review Comment:
enhance the line break? (move some words to L36?)
##########
hugegraph-hubble/pom.xml:
##########
@@ -55,6 +54,13 @@
<type>pom</type>
<scope>import</scope>
</dependency>
+ <dependency>
+ <groupId>com.fasterxml.jackson</groupId>
+ <artifactId>jackson-bom</artifactId>
+ <version>${jackson.version}</version>
+ <type>pom</type>
+ <scope>import</scope>
+ </dependency>
Review Comment:
why we need add jackson here? (seems client has included it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
