javeme commented on code in PR #480:
URL:
https://github.com/apache/incubator-hugegraph-toolchain/pull/480#discussion_r1261160828
##########
hugegraph-loader/src/main/java/org/apache/hugegraph/loader/constant/Constants.java:
##########
@@ -81,4 +81,6 @@ public final class Constants {
public static final String LOAD_DATA_PARSE_SUFFIX = "parse";
public static final String LOAD_DATA_SER_SUFFIX = "ser";
public static final String LOAD_DATA_INSERT_SUFFIX = "insert";
+ public static final String ACTION_DELETE = "delete";
Review Comment:
what happens if this 'delete' is passed for rocksdb backend?
##########
hugegraph-loader/src/main/java/org/apache/hugegraph/loader/executor/LoadOptions.java:
##########
@@ -217,22 +217,26 @@ public class LoadOptions implements Serializable {
description = "The number of partitions of the HBase vertex
table")
public int vertexPartitions = 64;
- @Parameter(names = {"edgeTablename"}, arity = 1,
- description = "edgeTablename")
+ @Parameter(names = {"--edge-table-name"}, arity = 1,
+ description = "The name of the the HBase edge table")
public String edgeTablename;
- @Parameter(names = {"vertexTablename"}, arity = 1,
- description = "vertexTablename")
+ @Parameter(names = {"--vertex-table-name"}, arity = 1,
+ description = "The name of the the HBase vertex table")
public String vertexTablename;
- @Parameter(names = {"hbaseZKQuorum"}, arity = 1,
- description = "hbaseZKQuorum")
+ @Parameter(names = {"--zk-quorum"}, arity = 1,
+ description = "Address of the zookeeper on which hbase depends")
public String hbaseZKQuorum;
- @Parameter(names = {"hbaseZKPort"}, arity = 1,
- description = "hbaseZKPort")
+ @Parameter(names = {"--zk-port"}, arity = 1,
+ description = "port of the zookeeper on which hbase depends")
public String hbaseZKPort;
- @Parameter(names = {"hbaseZKParent"}, arity = 1,
- description = "hbaseZKParent")
+ @Parameter(names = {"--zk-parent"}, arity = 1,
+ description = "hbase root node on the zookeeper")
public String hbaseZKParent;
+ @Parameter(names = {"--action-type"}, arity = 1,
+ description = "The type of operation performed on the
graph,update or delete")
Review Comment:
expect a space "graph,"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
