VGalaxies opened a new pull request, #2273: URL: https://github.com/apache/incubator-hugegraph/pull/2273
## Purpose of the PR reopen https://github.com/apache/incubator-hugegraph/pull/2270 subtask of https://github.com/apache/incubator-hugegraph/issues/2265 Merge the internal version of pd into hugegraph. <!-- Please explain more context in this section, clarify why the changes are needed. e.g: - If you propose a new API, clarify the use case for a new API. - If you fix a bug, you can clarify why it is a bug, and should be associated with an issue. --> ## Main Changes 1. Merge the internal version of pd into `hugegraph-pd` module. 2. Modified some pom files under the `hugegraph-pd` module so that it can be built normally **under certain conditions**. 3. Clean some comments in `hugegraph-pd`. 4. Add `apache-rat-plugin` for hugegraph-pd and add some license headers. 5. **(TODO)** potential code cleanup or style issues NOTE: 1. Due to the modification of `<parent>` in the root pom of `hugegraph-pd` from `spring-boot-starter-parent` to `hugegraph`, it is necessary to explicitly specify the version of some dependencies for the `hugegraph-pd` submodules. 2. The `hugegraph-pd` module incorporates features that are not supported in Java 8, such as the `var` keyword. To ensure compatibility with Java 8, subsequent PRs could consider adjusting the compilation version based on whether the user opts to use `hugegraph-pd` and `hugegraph-store`. <!-- Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. These change logs are helpful for better ant faster reviews.) For example: - If you introduce a new feature, please show detailed design here or add the link of design documentation. - If you refactor some codes with changing classes, showing the class hierarchy will help reviewers. - If there is a discussion in the mailing list, please add the link. --> ## Verifying these changes <!-- Please pick the proper options below --> - [ ] Trivial rework / code cleanup without any test coverage. (No Need) - [ ] Already covered by existing tests, such as *(please modify tests here)*. - [x] Need tests and can be verified as follows: - subsequent PRs will merge store and more adaptation work needs to be done ## Does this PR potentially affect the following parts? <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] Nope - [ ] Dependencies (add/update license info) <!-- Don't forget to add/update the info in "LICENSE" & "NOTICE" files (both in root & dist module) --> - [ ] Modify configurations - [ ] The public API - [x] Other affects (breaking changes) ## Documentation Status <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [x] `Doc - TODO` <!-- Your PR changes impact docs and you will update later --> - [ ] `Doc - Done` <!-- Related docs have been already added or updated --> - [ ] `Doc - No Need` <!-- Your PR changes don't impact/need docs --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
