imbajin commented on code in PR #2278:
URL:
https://github.com/apache/incubator-hugegraph/pull/2278#discussion_r1292386142
##########
hugegraph-dist/src/assembly/static/conf/arthas.yaml:
##########
@@ -0,0 +1,9 @@
+arthas:
+ # 通过 http 访问的端口
+ httpPort: 8561
+ # 通过 telnet 访问的端口
+ telnetPort: 8562
+ session-timeout: 1800
+ disabledCommands: jad
+ # 绑定的 ip
+ ip: 0.0.0.0
Review Comment:
expect a new line & could we merge these configs into one file?
(hg-configs.yaml?)
##########
hugegraph-test/src/main/java/org/apache/hugegraph/api/ArthasApiTest.java:
##########
@@ -0,0 +1,17 @@
+package org.apache.hugegraph.api;
+
+import org.junit.Test;
+
+import jakarta.ws.rs.core.Response;
+
+public class ArthasApiTest extends BaseApiTest {
+
+
+ private static final String path = "/arthasstart";
+
+ @Test
+ public void testMetricsAll() {
+ Response r = client().get(path);
+ assertResponseStatus(200, r);
+ }
Review Comment:
add some more basic case?
like init/stop/memory..
##########
hugegraph-dist/src/assembly/static/conf/rest-server.properties:
##########
@@ -9,6 +9,12 @@ graphs=./conf/graphs
batch.max_write_ratio=80
batch.max_write_threads=0
+# configuration of arthas
+arthas.telnetPort=8562
+arthas.httpPort=8561
+arthas.ip=0.0.0.0
+arthas.disabledCommands=jad
Review Comment:
like config here?
##########
hugegraph-dist/src/assembly/static/conf/arthas.yaml:
##########
@@ -0,0 +1,9 @@
+arthas:
+ # 通过 http 访问的端口
Review Comment:
use english comment, so as the pr title thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
