imbajin commented on PR #508: URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/508#issuecomment-1681026562
> > Overall looks good, but we need fix ci first and improve codestyle refer to [apache/incubator-hugegraph@`master`/hugegraph-style.xml](https://github.com/apache/incubator-hugegraph/blob/master/hugegraph-style.xml?rgh-link-date=2023-08-16T17%3A32%3A51Z) > > I've done my best to fix the issues mentioned on,but there is one more problem. When I add the licence header in the file "hugegraph-client/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker",the unit test will run error. if u point this, exclude it in [plugin settings](https://github.com/apache/incubator-hugegraph-toolchain/blob/master/.licenserc.yaml#L54) if we really don't need or can't add license header in it (also check `maven-rat` in pom.xml) <img width="1108" alt="image" src="https://github.com/apache/incubator-hugegraph-toolchain/assets/17706099/9486864c-9328-4736-adae-74cce5055035";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
