imbajin commented on code in PR #2296:
URL:
https://github.com/apache/incubator-hugegraph/pull/2296#discussion_r1306299687
##########
.github/workflows/ci.yml:
##########
@@ -46,15 +47,42 @@ jobs:
with:
fetch-depth: 2
+ - name: cat settings profile
+ if: ${{ env.USE_STAGE == 'true' }}
+ run: |
+ cat $HOME/.m2/settings.xml
+
+ - name: Modify settings.xml
Review Comment:
Modify maven settings
##########
.github/workflows/ci.yml:
##########
@@ -46,15 +47,42 @@ jobs:
with:
fetch-depth: 2
+ - name: cat settings profile
+ if: ${{ env.USE_STAGE == 'true' }}
+ run: |
+ cat $HOME/.m2/settings.xml
Review Comment:
seems no need cat here？
##########
.github/workflows/ci.yml:
##########
@@ -46,15 +47,42 @@ jobs:
with:
fetch-depth: 2
+ - name: cat settings profile
+ if: ${{ env.USE_STAGE == 'true' }}
+ run: |
+ cat $HOME/.m2/settings.xml
+
+ - name: Modify settings.xml
+ if: ${{ env.USE_STAGE == 'true' }}
+ run: |
+ sed -i
's/<\/settings>/<profiles><profile><id>local-repo<\/id><repositories><repository><id>central<\/id><url>https:\/\/repo.maven.apache.org\/maven2<\/url><releases><enabled>true<\/enabled><\/releases><snapshots><enabled>false<\/enabled><\/snapshots><\/repository><repository><id>staged-releases<\/id><url>https:\/\/repository.apache.org\/content\/groups\/staging\/<\/url><\/repository><\/repositories><pluginRepositories><pluginRepository><id>staged-releases<\/id><url>https:\/\/repository.apache.org\/content\/groups\/staging\/<\/url><\/pluginRepository><\/pluginRepositories><\/profile><\/profiles><activeProfiles><activeProfile>local-repo<\/activeProfile><\/activeProfiles><\/settings>/'
$HOME/.m2/settings.xml
+
+ - name: cat settings profile
+ if: ${{ env.USE_STAGE == 'true' }}
Review Comment:
seems we could merge 2 cmd to one step
##########
.github/workflows/ci.yml:
##########
@@ -46,15 +47,42 @@ jobs:
with:
fetch-depth: 2
+ - name: cat settings profile
+ if: ${{ env.USE_STAGE == 'true' }}
+ run: |
+ cat $HOME/.m2/settings.xml
+
+ - name: Modify settings.xml
+ if: ${{ env.USE_STAGE == 'true' }}
+ run: |
+ sed -i
's/<\/settings>/<profiles><profile><id>local-repo<\/id><repositories><repository><id>central<\/id><url>https:\/\/repo.maven.apache.org\/maven2<\/url><releases><enabled>true<\/enabled><\/releases><snapshots><enabled>false<\/enabled><\/snapshots><\/repository><repository><id>staged-releases<\/id><url>https:\/\/repository.apache.org\/content\/groups\/staging\/<\/url><\/repository><\/repositories><pluginRepositories><pluginRepository><id>staged-releases<\/id><url>https:\/\/repository.apache.org\/content\/groups\/staging\/<\/url><\/pluginRepository><\/pluginRepositories><\/profile><\/profiles><activeProfiles><activeProfile>local-repo<\/activeProfile><\/activeProfiles><\/settings>/'
$HOME/.m2/settings.xml
+
+ - name: cat settings profile
+ if: ${{ env.USE_STAGE == 'true' }}
+ run: |
+ cat $HOME/.m2/settings.xml
+
- name: Compile
run: |
mvn clean compile -U -Dmaven.javadoc.skip=true -ntp
+ - name: Install JDK ${{ matrix.JAVA_VERSION }}
+ uses: actions/setup-java@v3
+ with:
+ java-version: ${{ matrix.JAVA_VERSION }}
+ distribution: 'zulu'
+
- name: Install JDK 8
uses: actions/setup-java@v3
with:
java-version: '8'
distribution: 'zulu'
+
Review Comment:
why not specify a fixed copied settings.xml(rather than use the default file
& rewrite it many times)
##########
.github/workflows/ci.yml:
##########
@@ -46,15 +47,42 @@ jobs:
with:
fetch-depth: 2
+ - name: cat settings profile
+ if: ${{ env.USE_STAGE == 'true' }}
+ run: |
+ cat $HOME/.m2/settings.xml
+
+ - name: Modify settings.xml
+ if: ${{ env.USE_STAGE == 'true' }}
+ run: |
+ sed -i
's/<\/settings>/<profiles><profile><id>local-repo<\/id><repositories><repository><id>central<\/id><url>https:\/\/repo.maven.apache.org\/maven2<\/url><releases><enabled>true<\/enabled><\/releases><snapshots><enabled>false<\/enabled><\/snapshots><\/repository><repository><id>staged-releases<\/id><url>https:\/\/repository.apache.org\/content\/groups\/staging\/<\/url><\/repository><\/repositories><pluginRepositories><pluginRepository><id>staged-releases<\/id><url>https:\/\/repository.apache.org\/content\/groups\/staging\/<\/url><\/pluginRepository><\/pluginRepositories><\/profile><\/profiles><activeProfiles><activeProfile>local-repo<\/activeProfile><\/activeProfiles><\/settings>/'
$HOME/.m2/settings.xml
+
+ - name: cat settings profile
+ if: ${{ env.USE_STAGE == 'true' }}
+ run: |
+ cat $HOME/.m2/settings.xml
+
- name: Compile
run: |
mvn clean compile -U -Dmaven.javadoc.skip=true -ntp
+ - name: Install JDK ${{ matrix.JAVA_VERSION }}
+ uses: actions/setup-java@v3
+ with:
+ java-version: ${{ matrix.JAVA_VERSION }}
+ distribution: 'zulu'
+
Review Comment:
why need reinstall here?
##########
.github/workflows/ci.yml:
##########
@@ -46,15 +47,42 @@ jobs:
with:
fetch-depth: 2
+ - name: cat settings profile
+ if: ${{ env.USE_STAGE == 'true' }}
+ run: |
+ cat $HOME/.m2/settings.xml
Review Comment:
seems no need cat here？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
