imbajin commented on code in PR #2289:
URL:
https://github.com/apache/incubator-hugegraph/pull/2289#discussion_r1308568144
##########
hugegraph-pd/hg-pd-dist/src/assembly/static/bin/start-hugegraph-pd.sh:
##########
@@ -114,8 +114,8 @@ fi
echo "Starting HugeGraphPDServer..."
# Turn on security check
-exec ${JAVA} ${JAVA_OPTIONS} -jar
-Dspring.config.location=${CONF}/application.yml \
- ${LIB}/hugegraph-pd-*.jar >> ${OUTPUT} 2>&1 &
+exec ${JAVA} -Dname="HugeGraphPd" ${JAVA_OPTIONS} -jar \
Review Comment:
```suggestion
exec ${JAVA} -Dname="HugeGraphPD" ${JAVA_OPTIONS} -jar \
```
**TODO:**
@VGalaxies we could better get the `jar` version for the ** suffix of
name**, like `HugeGraphServer-1.0` | `HugeGraphPD-1.5` to let users know the
version directly
##########
hugegraph-pd/hg-pd-dist/src/assembly/static/bin/start-hugegraph-pd.sh:
##########
@@ -114,8 +114,8 @@ fi
echo "Starting HugeGraphPDServer..."
# Turn on security check
-exec ${JAVA} ${JAVA_OPTIONS} -jar
-Dspring.config.location=${CONF}/application.yml \
- ${LIB}/hugegraph-pd-*.jar >> ${OUTPUT} 2>&1 &
+exec ${JAVA} -Dname="HugeGraphPd" ${JAVA_OPTIONS} -jar \
Review Comment:
```suggestion
exec ${JAVA} -Dname="HugeGraphPD" ${JAVA_OPTIONS} -jar \
```
**TODO:**
@VGalaxies we could better get the `jar` version for the **suffix of name**,
like `HugeGraphServer-1.0` | `HugeGraphPD-1.5` to let users know the version
directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
