imbajin commented on code in PR #2302:
URL:
https://github.com/apache/incubator-hugegraph/pull/2302#discussion_r1309816122
##########
hugegraph-dist/src/assembly/static/bin/start-hugegraph.sh:
##########
@@ -18,12 +18,30 @@
OPEN_MONITOR="false"
OPEN_SECURITY_CHECK="true"
DAEMON="true"
-PRELOAD="false"
#VERBOSE=""
GC_OPTION=""
USER_OPTION=""
SERVER_STARTUP_TIMEOUT_S=30
+function abs_path() {
+ SOURCE="${BASH_SOURCE[0]}"
+ while [[ -h "$SOURCE" ]]; do
+ DIR="$(cd -P "$(dirname "$SOURCE")" && pwd)"
+ SOURCE="$(readlink "$SOURCE")"
+ [[ $SOURCE != /* ]] && SOURCE="$DIR/$SOURCE"
+ done
+ cd -P "$(dirname "$SOURCE")" && pwd
+}
Review Comment:
shall we move them to `util.sh`? (adjust the position)
##########
hugegraph-dist/src/assembly/static/bin/start-hugegraph.sh:
##########
@@ -35,45 +53,18 @@ while getopts "d:g:m:p:s:j:t:v" arg; do
t) SERVER_STARTUP_TIMEOUT_S="$OPTARG" ;;
# TODO: should remove it in future (check the usage carefully)
v) VERBOSE="verbose" ;;
- ?) echo "USAGE: $0 [-d true|false] [-g g1] [-m true|false] [-p
true|false] [-s true|false] [-j java_options]
- [-t timeout]" && exit 1 ;;
+ ?) exit_with_usage_help ;;
Review Comment:
add a `WARN`comment to update the usage info (if modify the options)
##########
hugegraph-dist/src/assembly/static/bin/start-hugegraph.sh:
##########
@@ -18,12 +18,30 @@
OPEN_MONITOR="false"
OPEN_SECURITY_CHECK="true"
DAEMON="true"
-PRELOAD="false"
Review Comment:
test it in binary package when we start with `bin/start-hugegraph.sh -p
true` (if we remove it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
