DanGuge commented on code in PR #2295:
URL: 
https://github.com/apache/incubator-hugegraph/pull/2295#discussion_r1311576441


##########
hugegraph-core/src/main/java/org/apache/hugegraph/backend/query/Query.java:
##########
@@ -560,25 +580,6 @@ public String toString() {
         return sb.toString();
     }
 
-    public static long defaultCapacity(long capacity) {
-        Long old = CAPACITY_CONTEXT.get();
-        CAPACITY_CONTEXT.set(capacity);
-        return old != null ? old : DEFAULT_CAPACITY;
-    }
-
-    public static long defaultCapacity() {
-        Long capacity = CAPACITY_CONTEXT.get();
-        return capacity != null ? capacity : DEFAULT_CAPACITY;
-    }
-
-    public static void checkForceCapacity(long count) throws 
LimitExceedException {
-        if (count > Query.DEFAULT_CAPACITY) {
-            throw new LimitExceedException(
-                      "Too many records(must <= %s) for one query",
-                      Query.DEFAULT_CAPACITY);
-        }
-    }
-

Review Comment:
   fixed



##########
hugegraph-core/src/main/java/org/apache/hugegraph/backend/tx/GraphTransaction.java:
##########
@@ -130,9 +114,18 @@ public class GraphTransaction extends IndexableTransaction 
{
     private final int commitPartOfAdjacentEdges;
     private final int batchSize;
     private final int pageSize;
-
     private final int verticesCapacity;
     private final int edgesCapacity;
+    private Map<Id, HugeVertex> addedVertices;
+    private Map<Id, HugeVertex> removedVertices;
+    private Map<Id, HugeEdge> addedEdges;
+    private Map<Id, HugeEdge> removedEdges;
+    private Set<HugeProperty<?>> addedProps;
+    private Set<HugeProperty<?>> removedProps;
+    // These are used to rollback state
+    private Map<Id, HugeVertex> updatedVertices;
+    private Map<Id, HugeEdge> updatedEdges;
+    private Set<HugeProperty<?>> updatedOldestProps; // Oldest props

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to