imbajin commented on code in PR #2305: URL: https://github.com/apache/incubator-hugegraph/pull/2305#discussion_r1315448138
########## .github/configs/settings.xml: ########## @@ -0,0 +1,41 @@ +<settings xmlns="http://maven.apache.org/SETTINGS/1.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0 https://maven.apache.org/xsd/settings-1.0.0.xsd";> + <servers> + <server> + <id>github</id> + <username>${env.GITHUB_ACTOR}</username> + <password>${env.GITHUB_TOKEN}</password> + </server> + </servers> + <profiles> + <profile> + <id>local-repo</id> + <repositories> + <repository> + <id>central</id> + <url>https://repo.maven.apache.org/maven2</url> + <releases> + <enabled>true</enabled> + </releases> + <snapshots> + <enabled>false</enabled> + </snapshots> + </repository> + <repository> + <id>staged-releases</id> + <url>https://repository.apache.org/content/groups/staging/</url> + </repository> + </repositories> + <pluginRepositories> + <pluginRepository> + <id>staged-releases</id> + <url>https://repository.apache.org/content/groups/staging/</url> + </pluginRepository> + </pluginRepositories> Review Comment: maybe we don't need it, although we could keep it now ########## .github/workflows/ci.yml: ########## @@ -46,22 +47,31 @@ jobs: with: fetch-depth: 2 + - name: copy and overwrite maven settings + if: ${{ env.USE_STAGE == 'true' }} + run: | + cp $HOME/.m2/settings.xml /tmp/settings.xml + mv -f .github/configs/settings.xml $HOME/.m2/settings.xml Review Comment: ```suggestion cp $HOME/.m2/settings.xml /tmp/settings.xml mv -vf .github/configs/settings.xml $HOME/.m2/settings.xml ``` ########## .github/workflows/ci.yml: ########## @@ -46,22 +47,31 @@ jobs: with: fetch-depth: 2 + - name: copy and overwrite maven settings Review Comment: ```suggestion - name: use staged maven repo settings ``` ########## .github/workflows/check-dependencies.yml: ########## @@ -23,6 +24,11 @@ jobs: with: java-version: '11' distribution: 'adopt' + - name: copy and overwrite maven settings Review Comment: ```suggestion - name: use staged maven repo settings ``` ########## .github/workflows/codeql-analysis.yml: ########## @@ -33,6 +35,12 @@ jobs: distribution: 'zulu' java-version: '11' + - name: copy and overwrite maven settings Review Comment: ```suggestion - name: use staged maven repo settings ``` ########## .github/configs/settings.xml: ########## @@ -0,0 +1,41 @@ +<settings xmlns="http://maven.apache.org/SETTINGS/1.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0 https://maven.apache.org/xsd/settings-1.0.0.xsd";> + <servers> + <server> + <id>github</id> + <username>${env.GITHUB_ACTOR}</username> + <password>${env.GITHUB_TOKEN}</password> + </server> + </servers> + <profiles> + <profile> + <id>local-repo</id> + <repositories> + <repository> + <id>central</id> + <url>https://repo.maven.apache.org/maven2</url> + <releases> + <enabled>true</enabled> + </releases> + <snapshots> + <enabled>false</enabled> + </snapshots> + </repository> + <repository> + <id>staged-releases</id> + <url>https://repository.apache.org/content/groups/staging/</url> + </repository> + </repositories> + <pluginRepositories> + <pluginRepository> + <id>staged-releases</id> + <url>https://repository.apache.org/content/groups/staging/</url> + </pluginRepository> + </pluginRepositories> + </profile> + </profiles> + <activeProfiles> Review Comment: ```suggestion </profiles> <activeProfiles> ``` ########## .github/configs/settings.xml: ########## @@ -0,0 +1,41 @@ +<settings xmlns="http://maven.apache.org/SETTINGS/1.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0 https://maven.apache.org/xsd/settings-1.0.0.xsd";> + <servers> + <server> + <id>github</id> + <username>${env.GITHUB_ACTOR}</username> + <password>${env.GITHUB_TOKEN}</password> + </server> + </servers> + <profiles> Review Comment: ```suggestion </servers> <profiles> ``` ########## .github/workflows/check-dependencies.yml: ########## @@ -23,6 +24,11 @@ jobs: with: java-version: '11' distribution: 'adopt' + - name: copy and overwrite maven settings + if: ${{ env.USE_STAGE == 'true' }} + run: | + cp $HOME/.m2/settings.xml /tmp/settings.xml + mv -f .github/configs/settings.xml $HOME/.m2/settings.xml Review Comment: ```suggestion cp $HOME/.m2/settings.xml /tmp/settings.xml mv -vf .github/configs/settings.xml $HOME/.m2/settings.xml ``` ########## .github/workflows/codeql-analysis.yml: ########## @@ -33,6 +35,12 @@ jobs: distribution: 'zulu' java-version: '11' + - name: copy and overwrite maven settings + if: ${{ env.USE_STAGE == 'true' }} + run: | + cp $HOME/.m2/settings.xml /tmp/settings.xml + mv -f .github/configs/settings.xml $HOME/.m2/settings.xml Review Comment: ```suggestion cp $HOME/.m2/settings.xml /tmp/settings.xml mv -vf .github/configs/settings.xml $HOME/.m2/settings.xml ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
