imbajin commented on code in PR #2307:
URL:
https://github.com/apache/incubator-hugegraph/pull/2307#discussion_r1320541029
##########
Dockerfile:
##########
@@ -50,11 +50,10 @@ RUN set -x \
# 2. Init HugeGraph Sever
RUN set -e \
&& pwd && cd /hugegraph/ \
- && sed -i "s/^restserver.url.*$/restserver.url=http:\/\/0.0.0.0:8080/g"
./conf/rest-server.properties \
- && ./bin/init-store.sh
+ && sed -i "s/^restserver.url.*$/restserver.url=http:\/\/0.0.0.0:8080/g"
./conf/rest-server.properties
EXPOSE 8080
VOLUME /hugegraph
ENTRYPOINT ["/usr/bin/dumb-init", "--"]
-CMD ["./bin/start-hugegraph.sh", "-d false -j $JAVA_OPTS -g zgc"]
+CMD ["./bin/docker-entrypoint.sh"]
Review Comment:
maybe we shouldn't put the `docker` files in general path?
##########
hugegraph-dist/docker/example/docker-compose-cassandra.yml:
##########
@@ -0,0 +1,44 @@
+version: "3"
+
+services:
+ graph:
+ image: hugegraph/hugegraph
+ container_name: ca-graph
+ ports:
+ - 18080:8080
+ environment:
+ hugegraph.backend: cassandra
+ hugegraph.serializer: cassandra
+ hugegraph.cassandra.host: ca-cassandra
+ hugegraph.cassandra.port: 9042
+ networks:
+ - ca-network
+ depends_on:
+ - cassandra
+ healthcheck:
+ test: ["CMD", "bin/gremlin-console.sh", "--" ,"-e",
"scripts/remote-connect.groovy"]
Review Comment:
we still need `-e`?
##########
hugegraph-dist/docker/example/docker-compose-cassandra.yml:
##########
@@ -0,0 +1,44 @@
+version: "3"
+
+services:
+ graph:
+ image: hugegraph/hugegraph
+ container_name: ca-graph
+ ports:
+ - 18080:8080
+ environment:
+ hugegraph.backend: cassandra
+ hugegraph.serializer: cassandra
+ hugegraph.cassandra.host: ca-cassandra
+ hugegraph.cassandra.port: 9042
+ networks:
+ - ca-network
+ depends_on:
+ - cassandra
+ healthcheck:
+ test: ["CMD", "bin/gremlin-console.sh", "--" ,"-e",
"scripts/remote-connect.groovy"]
+ interval: 10s
+ timeout: 30s
+ retries: 3
+
+ cassandra:
+ image: cassandra:3.11
Review Comment:
try C* 4 for it
##########
.gitignore:
##########
@@ -83,3 +83,5 @@ hs_err_pid*
.mtj.tmp/
# blueJ files
*.ctxt
+
+*swagger-ui*
Review Comment:
seems no need to add here due to the master code has fixed it (#2277)
##########
hugegraph-dist/src/assembly/static/bin/docker-entrypoint.sh:
##########
@@ -0,0 +1,24 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with this
+# work for additional information regarding copyright ownership. The ASF
+# licenses this file to You under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+#
+
+
+./bin/wait-storage.sh
+
+./bin/init-store.sh
+
+./bin/start-hugegraph.sh -d false -j "$JAVA_OPTS" -g zgc
Review Comment:
why the params here? could we get the value of `$JAVA_OPTS`?
##########
hugegraph-dist/docker/example/docker-compose-cassandra.yml:
##########
@@ -0,0 +1,44 @@
+version: "3"
+
+services:
+ graph:
+ image: hugegraph/hugegraph
+ container_name: ca-graph
Review Comment:
```suggestion
container_name: cas-graph
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
