javeme commented on code in PR #2242:
URL:
https://github.com/apache/incubator-hugegraph/pull/2242#discussion_r1320681394
##########
hugegraph-core/src/main/java/org/apache/hugegraph/traversal/algorithm/EdgeExistenceTraverser.java:
##########
@@ -0,0 +1,49 @@
+package org.apache.hugegraph.traversal.algorithm;
+
+import org.apache.hugegraph.HugeGraph;
+import org.apache.hugegraph.backend.id.Id;
+import org.apache.hugegraph.backend.query.ConditionQuery;
+import org.apache.hugegraph.backend.query.QueryResults;
+import org.apache.hugegraph.iterator.ListIterator;
+import org.apache.hugegraph.schema.EdgeLabel;
+import org.apache.hugegraph.type.HugeType;
+import org.apache.hugegraph.type.define.Directions;
+import org.apache.hugegraph.type.define.HugeKeys;
+import org.apache.tinkerpop.gremlin.structure.Edge;
+
+import java.util.Iterator;
+import java.util.List;
+
+public class EdgeExistenceTraverser extends HugeTraverser {
+ public EdgeExistenceTraverser(HugeGraph graph) {
+ super(graph);
+ }
+
+ public Iterator<Edge> queryEdgeExistence(Id sourceId, Id targetId, String
label,
+ String sortValues, long limit) {
+ if (label == null || label.isEmpty()) {
+ return queryByNeighbor(sourceId, targetId, limit);
+ }
+ Id edgeLabelId = getEdgeLabelId(label);
+ EdgeLabel edgeLabel = EdgeLabel.undefined(graph(), edgeLabelId);
+ ConditionQuery conditionQuery = new ConditionQuery(HugeType.EDGE);
+ conditionQuery.eq(HugeKeys.OWNER_VERTEX, sourceId);
+ conditionQuery.eq(HugeKeys.OTHER_VERTEX, targetId);
+ conditionQuery.eq(HugeKeys.LABEL, edgeLabelId);
+ conditionQuery.eq(HugeKeys.DIRECTION, Directions.OUT);
+ conditionQuery.limit(limit);
+ if (edgeLabel.existSortKeys()) {
+ conditionQuery.eq(HugeKeys.SORT_VALUES, sortValues);
+ }else {
Review Comment:
expect a space before "else"
##########
hugegraph-api/src/main/java/org/apache/hugegraph/api/traversers/EdgeExistenceAPI.java:
##########
@@ -0,0 +1,57 @@
+package org.apache.hugegraph.api.traversers;
Review Comment:
please add license header
##########
hugegraph-core/src/main/java/org/apache/hugegraph/traversal/algorithm/EdgeExistenceTraverser.java:
##########
@@ -0,0 +1,49 @@
+package org.apache.hugegraph.traversal.algorithm;
+
+import org.apache.hugegraph.HugeGraph;
+import org.apache.hugegraph.backend.id.Id;
+import org.apache.hugegraph.backend.query.ConditionQuery;
+import org.apache.hugegraph.backend.query.QueryResults;
+import org.apache.hugegraph.iterator.ListIterator;
+import org.apache.hugegraph.schema.EdgeLabel;
+import org.apache.hugegraph.type.HugeType;
+import org.apache.hugegraph.type.define.Directions;
+import org.apache.hugegraph.type.define.HugeKeys;
+import org.apache.tinkerpop.gremlin.structure.Edge;
+
+import java.util.Iterator;
+import java.util.List;
+
+public class EdgeExistenceTraverser extends HugeTraverser {
Review Comment:
expect a blank line after class define
##########
hugegraph-core/src/main/java/org/apache/hugegraph/traversal/algorithm/EdgeExistenceTraverser.java:
##########
@@ -0,0 +1,49 @@
+package org.apache.hugegraph.traversal.algorithm;
Review Comment:
please add license header
##########
hugegraph-core/src/main/java/org/apache/hugegraph/traversal/algorithm/EdgeExistenceTraverser.java:
##########
@@ -0,0 +1,49 @@
+package org.apache.hugegraph.traversal.algorithm;
+
+import org.apache.hugegraph.HugeGraph;
+import org.apache.hugegraph.backend.id.Id;
+import org.apache.hugegraph.backend.query.ConditionQuery;
+import org.apache.hugegraph.backend.query.QueryResults;
+import org.apache.hugegraph.iterator.ListIterator;
+import org.apache.hugegraph.schema.EdgeLabel;
+import org.apache.hugegraph.type.HugeType;
+import org.apache.hugegraph.type.define.Directions;
+import org.apache.hugegraph.type.define.HugeKeys;
+import org.apache.tinkerpop.gremlin.structure.Edge;
+
+import java.util.Iterator;
+import java.util.List;
+
+public class EdgeExistenceTraverser extends HugeTraverser {
+ public EdgeExistenceTraverser(HugeGraph graph) {
+ super(graph);
+ }
+
+ public Iterator<Edge> queryEdgeExistence(Id sourceId, Id targetId, String
label,
+ String sortValues, long limit) {
+ if (label == null || label.isEmpty()) {
+ return queryByNeighbor(sourceId, targetId, limit);
+ }
+ Id edgeLabelId = getEdgeLabelId(label);
+ EdgeLabel edgeLabel = EdgeLabel.undefined(graph(), edgeLabelId);
+ ConditionQuery conditionQuery = new ConditionQuery(HugeType.EDGE);
+ conditionQuery.eq(HugeKeys.OWNER_VERTEX, sourceId);
+ conditionQuery.eq(HugeKeys.OTHER_VERTEX, targetId);
+ conditionQuery.eq(HugeKeys.LABEL, edgeLabelId);
+ conditionQuery.eq(HugeKeys.DIRECTION, Directions.OUT);
+ conditionQuery.limit(limit);
+ if (edgeLabel.existSortKeys()) {
+ conditionQuery.eq(HugeKeys.SORT_VALUES, sortValues);
+ }else {
+ conditionQuery.eq(HugeKeys.SORT_VALUES, "");
+ }
+ return graph().edges(conditionQuery);
+ }
+
+ private Iterator<Edge> queryByNeighbor(Id sourceId, Id targetId, long
limit) {
+ ListIterator<Edge> edges =
QueryResults.toList(this.edgesOfVertex(sourceId, Directions.OUT, (Id) null,
limit));
+ List<Edge> res = newList();
+ edges.forEachRemaining(edge -> {if (targetId.compareTo((Id)
edge.inVertex().id()) == 0) res.add(edge);});
Review Comment:
can we use for-loop instead? to keep a consistent style and reduce the times
of callbacks
##########
hugegraph-api/src/main/java/org/apache/hugegraph/api/traversers/EdgeExistenceAPI.java:
##########
@@ -0,0 +1,57 @@
+package org.apache.hugegraph.api.traversers;
+
+import static
org.apache.hugegraph.traversal.algorithm.HugeTraverser.DEFAULT_LIMIT;
+
+import com.codahale.metrics.annotation.Timed;
+import io.swagger.v3.oas.annotations.tags.Tag;
+import jakarta.inject.Singleton;
+import jakarta.ws.rs.*;
+import jakarta.ws.rs.core.Context;
+import org.apache.hugegraph.HugeGraph;
+import org.apache.hugegraph.backend.id.Id;
+import org.apache.hugegraph.core.GraphManager;
+import org.apache.hugegraph.structure.HugeVertex;
+import org.apache.hugegraph.traversal.algorithm.EdgeExistenceTraverser;
+import org.apache.hugegraph.util.E;
+import org.apache.hugegraph.util.Log;
+import org.apache.tinkerpop.gremlin.structure.Edge;
+import org.slf4j.Logger;
+
+import java.util.Iterator;
+
+@Path("graphs/{graph}/traversers/edgeexistence")
Review Comment:
`edgeexist` is ok
##########
hugegraph-core/src/main/java/org/apache/hugegraph/traversal/algorithm/EdgeExistenceTraverser.java:
##########
@@ -0,0 +1,49 @@
+package org.apache.hugegraph.traversal.algorithm;
+
+import org.apache.hugegraph.HugeGraph;
+import org.apache.hugegraph.backend.id.Id;
+import org.apache.hugegraph.backend.query.ConditionQuery;
+import org.apache.hugegraph.backend.query.QueryResults;
+import org.apache.hugegraph.iterator.ListIterator;
+import org.apache.hugegraph.schema.EdgeLabel;
+import org.apache.hugegraph.type.HugeType;
+import org.apache.hugegraph.type.define.Directions;
+import org.apache.hugegraph.type.define.HugeKeys;
+import org.apache.tinkerpop.gremlin.structure.Edge;
+
+import java.util.Iterator;
+import java.util.List;
+
+public class EdgeExistenceTraverser extends HugeTraverser {
+ public EdgeExistenceTraverser(HugeGraph graph) {
+ super(graph);
+ }
+
+ public Iterator<Edge> queryEdgeExistence(Id sourceId, Id targetId, String
label,
+ String sortValues, long limit) {
+ if (label == null || label.isEmpty()) {
+ return queryByNeighbor(sourceId, targetId, limit);
+ }
+ Id edgeLabelId = getEdgeLabelId(label);
+ EdgeLabel edgeLabel = EdgeLabel.undefined(graph(), edgeLabelId);
+ ConditionQuery conditionQuery = new ConditionQuery(HugeType.EDGE);
+ conditionQuery.eq(HugeKeys.OWNER_VERTEX, sourceId);
+ conditionQuery.eq(HugeKeys.OTHER_VERTEX, targetId);
+ conditionQuery.eq(HugeKeys.LABEL, edgeLabelId);
+ conditionQuery.eq(HugeKeys.DIRECTION, Directions.OUT);
+ conditionQuery.limit(limit);
+ if (edgeLabel.existSortKeys()) {
+ conditionQuery.eq(HugeKeys.SORT_VALUES, sortValues);
+ }else {
+ conditionQuery.eq(HugeKeys.SORT_VALUES, "");
+ }
+ return graph().edges(conditionQuery);
+ }
+
+ private Iterator<Edge> queryByNeighbor(Id sourceId, Id targetId, long
limit) {
+ ListIterator<Edge> edges =
QueryResults.toList(this.edgesOfVertex(sourceId, Directions.OUT, (Id) null,
limit));
+ List<Edge> res = newList();
Review Comment:
prefer results
##########
hugegraph-core/src/main/java/org/apache/hugegraph/traversal/algorithm/EdgeExistenceTraverser.java:
##########
@@ -0,0 +1,49 @@
+package org.apache.hugegraph.traversal.algorithm;
+
+import org.apache.hugegraph.HugeGraph;
+import org.apache.hugegraph.backend.id.Id;
+import org.apache.hugegraph.backend.query.ConditionQuery;
+import org.apache.hugegraph.backend.query.QueryResults;
+import org.apache.hugegraph.iterator.ListIterator;
+import org.apache.hugegraph.schema.EdgeLabel;
+import org.apache.hugegraph.type.HugeType;
+import org.apache.hugegraph.type.define.Directions;
+import org.apache.hugegraph.type.define.HugeKeys;
+import org.apache.tinkerpop.gremlin.structure.Edge;
+
+import java.util.Iterator;
+import java.util.List;
+
+public class EdgeExistenceTraverser extends HugeTraverser {
+ public EdgeExistenceTraverser(HugeGraph graph) {
+ super(graph);
+ }
+
+ public Iterator<Edge> queryEdgeExistence(Id sourceId, Id targetId, String
label,
+ String sortValues, long limit) {
+ if (label == null || label.isEmpty()) {
+ return queryByNeighbor(sourceId, targetId, limit);
+ }
+ Id edgeLabelId = getEdgeLabelId(label);
+ EdgeLabel edgeLabel = EdgeLabel.undefined(graph(), edgeLabelId);
+ ConditionQuery conditionQuery = new ConditionQuery(HugeType.EDGE);
+ conditionQuery.eq(HugeKeys.OWNER_VERTEX, sourceId);
+ conditionQuery.eq(HugeKeys.OTHER_VERTEX, targetId);
+ conditionQuery.eq(HugeKeys.LABEL, edgeLabelId);
+ conditionQuery.eq(HugeKeys.DIRECTION, Directions.OUT);
+ conditionQuery.limit(limit);
+ if (edgeLabel.existSortKeys()) {
+ conditionQuery.eq(HugeKeys.SORT_VALUES, sortValues);
+ }else {
+ conditionQuery.eq(HugeKeys.SORT_VALUES, "");
+ }
+ return graph().edges(conditionQuery);
+ }
+
+ private Iterator<Edge> queryByNeighbor(Id sourceId, Id targetId, long
limit) {
Review Comment:
prefer queryByNeighbors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
