javeme commented on code in PR #2295:
URL:
https://github.com/apache/incubator-hugegraph/pull/2295#discussion_r1320715953
##########
hugegraph-api/src/main/java/org/apache/hugegraph/api/traversers/KoutAPI.java:
##########
@@ -237,19 +237,19 @@ private static class Request {
public boolean withPath = false;
@JsonProperty("with_edge")
public boolean withEdge = false;
- @JsonProperty("algorithm")
- public String algorithm = HugeTraverser.TRAVERSE_MODE_BFS;
+ @JsonProperty("traverse_mode")
+ public String traverse_mode = HugeTraverser.TRAVERSE_MODE_BFS;
Review Comment:
keep var name traverseMode style
##########
hugegraph-core/src/main/java/org/apache/hugegraph/traversal/algorithm/HugeTraverser.java:
##########
@@ -178,8 +178,8 @@ public static void checkTraverseMode(String traverseMode) {
TRAVERSE_MODE_BFS, TRAVERSE_MODE_DFS, traverseMode);
}
- public static boolean isTraverseModeDFS(String algorithm) {
- return algorithm.compareToIgnoreCase(TRAVERSE_MODE_DFS) == 0;
+ public static boolean isTraverseModeDFS(String traverse_mode) {
Review Comment:
ditto
##########
hugegraph-api/src/main/java/org/apache/hugegraph/api/traversers/KoutAPI.java:
##########
@@ -237,19 +237,19 @@ private static class Request {
public boolean withPath = false;
@JsonProperty("with_edge")
public boolean withEdge = false;
- @JsonProperty("algorithm")
- public String algorithm = HugeTraverser.TRAVERSE_MODE_BFS;
+ @JsonProperty("traverse_mode")
+ public String traverse_mode = HugeTraverser.TRAVERSE_MODE_BFS;
@Override
public String toString() {
return String.format("KoutRequest{source=%s,steps=%s,maxDepth=%s" +
"nearest=%s,countOnly=%s,capacity=%s," +
"limit=%s,withVertex=%s,withPath=%s," +
- "withEdge=%s,algorithm=%s}", this.source,
+ "withEdge=%s,traverse_mode=%s}", this.source,
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
