SunnyBoy-WYH commented on code in PR #2299:
URL:
https://github.com/apache/incubator-hugegraph/pull/2299#discussion_r1333108673
##########
hugegraph-core/src/main/java/org/apache/hugegraph/auth/StandardAuthManager.java:
##########
@@ -77,6 +76,10 @@ public class StandardAuthManager implements AuthManager {
private final TokenGenerator tokenGenerator;
private final long tokenExpire;
+ private List<String> ipWhiteList;
Review Comment:
> > mark final maybe we cant change it anymore?
>
> for `Object`, `final`/`static` will just fix the **Memory Pointer
Address**, won't influence the **inner value**
>
> just like the **head pointer** in the linked list
like this？
##########
hugegraph-core/src/main/java/org/apache/hugegraph/auth/StandardAuthManager.java:
##########
@@ -77,6 +76,10 @@ public class StandardAuthManager implements AuthManager {
private final TokenGenerator tokenGenerator;
private final long tokenExpire;
+ private List<String> ipWhiteList;
Review Comment:
> > mark final maybe we cant change it anymore?
>
> for `Object`, `final`/`static` will just fix the **Memory Pointer
Address**, won't influence the **inner value**
>
> just like the **head pointer** in the linked list
like this？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
