javeme commented on code in PR #269:
URL:
https://github.com/apache/incubator-hugegraph-computer/pull/269#discussion_r1341999698
##########
computer-api/src/main/java/org/apache/hugegraph/computer/core/config/ComputerOptions.java:
##########
@@ -198,6 +198,62 @@ public static synchronized ComputerOptions instance() {
""
);
+ public static final ConfigOption<Boolean> SNAPSHOT_WRITE =
+ new ConfigOption<>(
+ "snapshot.write",
+ "Whether write snapshot of input vertex and edge
partitions",
Review Comment:
prefer `Whether to do snapshot for verte/edge partitions`
##########
computer-api/src/main/java/org/apache/hugegraph/computer/core/config/ComputerOptions.java:
##########
@@ -198,6 +198,62 @@ public static synchronized ComputerOptions instance() {
""
);
+ public static final ConfigOption<Boolean> SNAPSHOT_WRITE =
+ new ConfigOption<>(
+ "snapshot.write",
+ "Whether write snapshot of input vertex and edge
partitions",
+ allowValues(true, false),
+ false
+ );
+
+ public static final ConfigOption<Boolean> SNAPSHOT_LOAD =
+ new ConfigOption<>(
+ "snapshot.load",
+ "Whether use snapshot of input vertex and edge partitions",
+ allowValues(true, false),
+ false
+ );
+
+ public static final ConfigOption<String> SNAPSHOT_VIEW_KEY =
+ new ConfigOption<>(
+ "snapshot.view_key",
+ "View key of target snapshot",
+ null,
+ ""
+ );
+
+ public static final ConfigOption<String> SNAPSHOT_MINIO_ENDPOINT =
+ new ConfigOption<>(
+ "snapshot.minio_endpoint",
+ "MinIO endpoint",
Review Comment:
prefer `The endpoint of MinIO, MinIO can be used to store snapshots.`
##########
computer-api/src/main/java/org/apache/hugegraph/computer/core/config/ComputerOptions.java:
##########
@@ -198,6 +198,62 @@ public static synchronized ComputerOptions instance() {
""
);
+ public static final ConfigOption<Boolean> SNAPSHOT_WRITE =
+ new ConfigOption<>(
+ "snapshot.write",
+ "Whether write snapshot of input vertex and edge
partitions",
+ allowValues(true, false),
+ false
+ );
+
+ public static final ConfigOption<Boolean> SNAPSHOT_LOAD =
+ new ConfigOption<>(
+ "snapshot.load",
+ "Whether use snapshot of input vertex and edge partitions",
+ allowValues(true, false),
+ false
+ );
+
+ public static final ConfigOption<String> SNAPSHOT_VIEW_KEY =
+ new ConfigOption<>(
+ "snapshot.view_key",
+ "View key of target snapshot",
Review Comment:
what does the view key mean? do we have a concept that is easier to
understand?
##########
computer-test/src/main/java/org/apache/hugegraph/computer/core/compute/input/EdgesInputTest.java:
##########
@@ -137,6 +138,11 @@ private void testEdgeFreq(EdgeFrequency freq)
fileManager,
sortManager);
this.managers.add(receiveManager);
+ SnapshotManager snapshotManager = new SnapshotManager(context(),
+ null,
Review Comment:
ditto
##########
computer-test/src/main/java/org/apache/hugegraph/computer/core/compute/ComputeManagerTest.java:
##########
@@ -104,6 +105,11 @@ public void setup() {
fileManager,
sortManager);
this.managers.add(receiveManager);
+ SnapshotManager snapshotManager = new SnapshotManager(context(),
+ null,
Review Comment:
prefer to align with "context()"
##########
computer-api/src/main/java/org/apache/hugegraph/computer/core/config/ComputerOptions.java:
##########
@@ -198,6 +198,62 @@ public static synchronized ComputerOptions instance() {
""
);
+ public static final ConfigOption<Boolean> SNAPSHOT_WRITE =
+ new ConfigOption<>(
+ "snapshot.write",
+ "Whether write snapshot of input vertex and edge
partitions",
+ allowValues(true, false),
+ false
+ );
+
+ public static final ConfigOption<Boolean> SNAPSHOT_LOAD =
+ new ConfigOption<>(
+ "snapshot.load",
+ "Whether use snapshot of input vertex and edge partitions",
Review Comment:
prefer `Whether to load from snapshot of vertex/edge partitions`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
