imbajin commented on PR #514: URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/514#issuecomment-1774810340
Although I have replaced all tab to 4 spaces, I found this rule is set by `go fmt` by default(the official format tool), Its design concept is to use tabs for line breaks and **spaces** for alignment[1] This means that we need to show a reminder to inform the devs that `USE space` & `4 spaces` need to be **specified** for go here. Additionally, if go projects generally use **8 spaces** for indentation, we can consider continuing to use 8 spaces instead of 4, or maybe use the **default config with tab** instead @javeme @zyxxoo? And I checked some go projects in apache, seems they also use TAB(1 tab = 8 space) for default. Refer: 1. apache [dubbo-go](https://github.com/apache/dubbo-go/blob/main/tools/dubbogo-cli/generator/application/gomod.go) 2. https://github.com/apache/incubator-answer/blob/main/cmd/command.go 3. https://github.com/apache/incubator-devlake/blob/main/backend/test/e2e/manual/pagerduty/models.go -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
