javeme commented on code in PR #2347:
URL:
https://github.com/apache/incubator-hugegraph/pull/2347#discussion_r1390126964
##########
hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/api/filter/AccessLogFilter.java:
##########
@@ -57,17 +55,38 @@ public class AccessLogFilter implements
ContainerResponseFilter {
@Context
private jakarta.inject.Provider<HugeConfig> configProvider;
+ public static boolean needRecord(ContainerRequestContext context) {
Review Comment:
prefer needRecordLog
##########
hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/api/filter/PathFilter.java:
##########
@@ -42,23 +34,25 @@ public class PathFilter implements ContainerRequestFilter {
public static final String REQUEST_PARAMS_JSON = "request_params_json";
@Override
- public void filter(ContainerRequestContext context)
- throws IOException {
+ public void filter(ContainerRequestContext context) throws IOException {
context.setProperty(REQUEST_TIME, System.currentTimeMillis());
- // record the request json
+ // TODO: comment it to fix loader bug, handle it later
Review Comment:
`temporarily comment it to fix a loader bug, uncomment it later`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
