imbajin commented on code in PR #2349:
URL:
https://github.com/apache/incubator-hugegraph/pull/2349#discussion_r1391288502
##########
.github/workflows/ci.yml:
##########
@@ -20,11 +20,12 @@ jobs:
BASE_BRANCH_NAME: ${{ github.base_ref }}
TARGET_BRANCH_NAME: ${{ github.base_ref != '' && github.base_ref ||
github.ref_name }}
RELEASE_BRANCH: ${{ startsWith(github.ref_name, 'release-') ||
startsWith(github.ref_name, 'test-') }}
+ RAFT_MODE: ${{ startsWith(github.head_ref, 'test') ||
startsWith(github.head_ref, 'raft') }}
Review Comment:
> `${{ startsWith(github.head_ref, 'raft-') || startsWith(github.head_ref,
'test-') }}`
due to “head_ref” is based on the users/dev branch name（not ours）
use “a*” mode is more common for them（also consider use `contains('a*')` api
in future）
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
