imbajin commented on code in PR #538:
URL:
https://github.com/apache/incubator-hugegraph-toolchain/pull/538#discussion_r1403927737
##########
hugegraph-dist/scripts/dependency/known-dependencies.txt:
##########
@@ -136,12 +133,11 @@ jackson-module-jaxb-annotations-2.12.3.jar
jackson-module-parameter-names-2.12.3.jar
jakarta.activation-2.0.1.jar
jakarta.activation-api-1.2.1.jar
-jakarta.annotation-api-2.0.0.jar
-jakarta.inject-api-2.0.0.jar
-jakarta.validation-api-3.0.0.jar
-jakarta.ws.rs-api-3.0.0.jar
+jersey-container-servlet-core-2.25.1.jar
+jersey-container-servlet-core-2.27.jar
Review Comment:
Unexpected import?
##########
hugegraph-client/src/main/java/org/apache/hugegraph/api/graph/EdgeAPI.java:
##########
@@ -21,8 +21,10 @@
import java.util.List;
import java.util.Map;
+import okhttp3.Headers;
Review Comment:
seems useless import?
##########
hugegraph-client/pom.xml:
##########
@@ -48,15 +49,18 @@
<groupId>org.lz4</groupId>
<artifactId>lz4-java</artifactId>
</dependency>
- <dependency>
- <groupId>org.glassfish.jersey.containers</groupId>
- <artifactId>jersey-container-servlet</artifactId>
- </dependency>
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
<scope>test</scope>
</dependency>
+
+ <dependency>
+ <groupId>org.projectlombok</groupId>
+ <artifactId>lombok</artifactId>
+ <version>${lombok.version}</version>
+ <optional>true</optional>
+ </dependency>
Review Comment:
including by common already?
##########
hugegraph-hubble/hubble-be/pom.xml:
##########
@@ -92,6 +93,24 @@
<dependency>
<groupId>org.apache.hugegraph</groupId>
<artifactId>hugegraph-common</artifactId>
+ <exclusions>
+ <exclusion>
+ <groupId>org.glassfish.jersey.core</groupId>
+ <artifactId>jersey-client</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.glassfish.jersey.media</groupId>
+ <artifactId>jersey-media-json-jackson</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.glassfish.jersey.connectors</groupId>
+ <artifactId>jersey-apache-connector</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.glassfish.jersey.inject</groupId>
+ <artifactId>jersey-hk2</artifactId>
+ </exclusion>
Review Comment:
maybe outdated, I'll delete them in next commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
