imbajin commented on code in PR #538: URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/538#discussion_r1414896236
########## .github/workflows/hubble-ci.yml: ########## @@ -23,7 +24,7 @@ on: env: TRAVIS_DIR: hugegraph-hubble/hubble-dist/assembly/travis # TODO: need update it later (eed6103359fe40d2f1476fb8c56d9388c3111a99) - COMMIT_ID: be6ee386b9939dc6bd6fcbdf2274b8acc3a0a314 + COMMIT_ID: 69e6b461add1051831dd6cc0c36a5e249a3b3176 Review Comment: > It is a method to use `latestCommitID - X`, but we can't control it freely. If we want to adapt to the latest code, we still need to change the X. we may try reusable-workflow: [docs.github.com/en/actions/using-workflows/reusing-workflows#using-inputs-and-secrets-in-a-reusable-workflow](https://docs.github.com/en/actions/using-workflows/reusing-workflows#using-inputs-and-secrets-in-a-reusable-workflow) Get it, but we can't set `secrets/variables` in settings, we lack the **permission** to set it 😢 (This is also the reason why in the early code, we could only write fixed commitID in multiple CI files) BTW, we could create/submit a `common action` and publish it to github action repo & let other actions to extend it if github supports -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
