coderzc commented on code in PR #286:
URL:
https://github.com/apache/incubator-hugegraph-computer/pull/286#discussion_r1418841084
##########
computer-core/src/main/java/org/apache/hugegraph/computer/core/master/MasterService.java:
##########
@@ -114,9 +113,9 @@ public void init(Config config) {
LOG.info("{} register MasterService", this);
this.bsp4Master.masterInitDone(this.masterInfo);
- this.workers = this.bsp4Master.waitWorkersInitDone();
+ List<ContainerInfo> workers = this.bsp4Master.waitWorkersInitDone();
LOG.info("{} waited all workers registered, workers count: {}",
- this, this.workers.size());
+ this, workers.size());
LOG.info("{} MasterService initialized", this);
this.inited = true;
Review Comment:
```suggestion
this.inited = true;
this.failed = true;
```
##########
computer-core/src/main/java/org/apache/hugegraph/computer/core/master/MasterService.java:
##########
@@ -114,9 +113,9 @@ public void init(Config config) {
LOG.info("{} register MasterService", this);
this.bsp4Master.masterInitDone(this.masterInfo);
- this.workers = this.bsp4Master.waitWorkersInitDone();
+ List<ContainerInfo> workers = this.bsp4Master.waitWorkersInitDone();
LOG.info("{} waited all workers registered, workers count: {}",
- this, this.workers.size());
+ this, workers.size());
LOG.info("{} MasterService initialized", this);
this.inited = true;
Review Comment:
```suggestion
this.inited = true;
this.failed = true;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
