VGalaxies commented on code in PR #2200:
URL: 
https://github.com/apache/incubator-hugegraph/pull/2200#discussion_r1421935621


##########
hugegraph-server/hugegraph-rocksdb/src/main/java/org/apache/hugegraph/backend/store/rocksdbsst/RocksDBSstSessions.java:
##########
@@ -269,10 +269,9 @@ public Integer commit() {
                     }
 
                     // TODO: limit individual SST file size
-                    try (SstFileWriter sst = table(table.getKey())) {
-                        for (Pair<byte[], byte[]> change : table.getValue()) {
-                            sst.put(change.getKey(), change.getValue());
-                        }
+                    SstFileWriter sst = table(table.getKey());

Review Comment:
   FIX ME: 'SstFileWriter' used without 'try'-with-resources statement



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to