imbajin commented on code in PR #307:
URL:
https://github.com/apache/incubator-hugegraph-doc/pull/307#discussion_r1429462880
##########
.github/workflows/validate-release.yml:
##########
@@ -198,7 +199,8 @@ jobs:
cd ./*hubble*${{ inputs.release_version }} || exit
# TODO: add hubble doc & test it
cat conf/hugegraph-hubble.properties
- bin/start-hubble.sh && bin/stop-hubble.sh
+ bin/start-hubble.sh || exit
+ bin/stop-hubble.sh || exit
Review Comment:
> I remember that `start_hubble.sh` included the check:
>
>
[apache/incubator-hugegraph-toolchain@`773469c`/hugegraph-hubble/hubble-dist/assembly/static/bin/start-hubble.sh#L83-L94](https://github.com/apache/incubator-hugegraph-toolchain/blob/773469c069bc79e9e8159349a5b086f6da3f97eb/hugegraph-hubble/hubble-dist/assembly/static/bin/start-hubble.sh#L83-L94)
seems it only check server but not hubble itself (it's good to enhance the
check in `start-hubble` later), currently we could check it in our script
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
