javeme commented on code in PR #285:
URL:
https://github.com/apache/incubator-hugegraph-computer/pull/285#discussion_r1439028325
##########
computer-algorithm/src/main/java/org/apache/hugegraph/computer/algorithm/path/shortest/SingleSourceShortestPath.java:
##########
@@ -55,12 +57,17 @@ public class SingleSourceShortestPath implements
Computation<SingleSourceShortes
/**
* target vertex id.
- * 1. single target
- * 2. multiple target: comma separated
+ * 1. single target: one vertex id
+ * 2. multiple target: multiple vertex ids separated by comma
* 3. all: *
*/
private String targetId;
+ /**
+ * cache of targetId
+ */
+ private Set<String> targetIdSet;
Review Comment:
not sure why not use `Set<Id>` instead of `Set<String>` -- I'm worried that
losing the id type may introduce bugs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
