imbajin commented on code in PR #566:
URL: 
https://github.com/apache/incubator-hugegraph-toolchain/pull/566#discussion_r1444145098


##########
hugegraph-dist/scripts/dependency/known-dependencies.txt:
##########
@@ -50,14 +50,14 @@ datanucleus-core-4.1.17.jar
 disruptor-3.3.6.jar
 dnsjava-2.1.7.jar
 dropwizard-metrics-hadoop-metrics2-reporter-0.1.2.jar
-error_prone_annotations-2.18.0.jar
+error_prone_annotations-2.3.4.jar
 failureaccess-1.0.1.jar
 findbugs-annotations-1.3.9-1.jar
 flatbuffers-1.2.0-3f79e055.jar
 flatbuffers-java-1.9.0.jar
 groovy-all-2.4.21.jar
 gson-2.8.9.jar
-guava-32.0.1-jre.jar
+guava-30.0-jre.jar

Review Comment:
   > There is no guava conflict, but the version in hugegraph-common is 
30.0-jre. The guava package does not seem to be used in the toolchain. Can it 
be inherited directly?
   
   we do need to use common to manage `guava version` rather than define it 
separately (if common use 30.0, just  keep up with  it) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to