imbajin commented on code in PR #2422:
URL:
https://github.com/apache/incubator-hugegraph/pull/2422#discussion_r1458580283
##########
hugegraph-server/hugegraph-api/pom.xml:
##########
@@ -164,6 +164,12 @@
<artifactId>arthas-packaging</artifactId>
<version>${arthas.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.gridkit.jvmtool</groupId>
+ <artifactId>sjk-core</artifactId>
+ <version>0.22</version>
+ <scope>compile</scope>
+ </dependency>
Review Comment:
TODO: we need add license info for them
##########
hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/api/filter/AuthenticationFilter.java:
##########
@@ -314,9 +316,8 @@ public boolean equals(Object obj) {
public static boolean isWhiteAPI(ContainerRequestContext context) {
String path = context.getUriInfo().getPath();
-
for (String whiteApi : WHITE_API_LIST) {
- if (path.endsWith(whiteApi)) {
+ if (MATCHER.match(whiteApi, path)) {
Review Comment:
TODO: add some tests for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
