imbajin commented on code in PR #2421: URL: https://github.com/apache/incubator-hugegraph/pull/2421#discussion_r1458628677
########## hugegraph-server/hugegraph-dist/docker/docker-entrypoint.sh: ########## @@ -34,6 +34,7 @@ else fi # start hugegraph -./bin/start-hugegraph.sh -j "$JAVA_OPTS" -g zgc +# remove -g zgc, which is only available on mac with java > 13 Review Comment: ```suggestion # remove "-g zgc" now, which is only available on ARM-Mac with java > 13 ``` ########## hugegraph-server/Dockerfile: ########## @@ -26,6 +26,7 @@ ARG MAVEN_ARGS RUN mvn package $MAVEN_ARGS -e -B -ntp -DskipTests -Dmaven.javadoc.skip=true && pwd && ls -l # 2nd stage: runtime env +# remove zgc, which is only available on mac with java > 13 Review Comment: ```suggestion # remove zgc, which is only available on ARM-Mac with java > 13 ``` ########## hugegraph-server/hugegraph-dist/docker/docker-entrypoint.sh: ########## Review Comment: Also add a comment on `*hugegraph.sh` in dist? "Comment for ZGC" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
