imbajin commented on PR #2478: URL: https://github.com/apache/incubator-hugegraph/pull/2478#issuecomment-2016818490
> One more suggestion, we can split the files under the pd client into multiple directories according to functions, and provide Clients.java for navigation(like `Clients.createXxClient()`). In addition, the files naming of pd proto need to be classified/formatted. @javeme @zyxxoo The **code-style** related issues(name/comment/format/clean) may list first(although we already cleaned a lot of them..), the style problems are better to be **modified together** after reaching TODOs to avoid more **inconsistencies** under version merge. For now, we can first focus on the problems in **code logic** and **implementation**, which can only be considered as a tradeoff 😿 (so as the PR #2272 ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
