VGalaxies commented on code in PR #342: URL: https://github.com/apache/incubator-hugegraph-doc/pull/342#discussion_r1548054956
########## dist/validate-release.sh: ########## @@ -21,8 +21,8 @@ # 3. Compile the source package & run server & toolchain # 4. Run server & toolchain in binary package -# if we don't want to exit after '|', remove "-o pipefail" -set -exo pipefail +# exit when any error occurs +set -e Review Comment: I understand that if the command `grep -E "$CATEGORY_X" LICENSE NOTICE` returns an error, using `set -o pipefail` will cause the script to exit prematurely. If it's possible to avoid the above command from erroring out, for example, by ensuring that the regular expression syntax is correct and that the `LICENSE` and `NOTICE` files exist and have read permissions, then we can keep `set -o pipefail`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
