imbajin commented on code in PR #2458:
URL:
https://github.com/apache/incubator-hugegraph/pull/2458#discussion_r1565319553
##########
hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/api/traversers/Vertices.java:
##########
@@ -51,6 +52,10 @@ public Iterator<Vertex> vertices(HugeGraph g) {
this.label == null), "No source vertices provided");
Iterator<Vertex> iterator;
if (this.ids != null && !this.ids.isEmpty()) {
+ E.checkArgument(this.label == null,
+ "Just provide one of ids or label of source
vertices");
+ E.checkArgument(props == null || props.isEmpty(),
+ "Just provide one of ids or properties of source
vertices");
Review Comment:
NOTE: it's a `BREAKING CHANGE`, we need change the PR title to `BREAKING
CHANGE: xxx` in the future & alert the users/devs to check it
related CI error when upgrade the server:
https://github.com/apache/incubator-hugegraph-ai/actions/runs/8673001982/job/23783894307
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
