imbajin commented on code in PR #47: URL: https://github.com/apache/incubator-hugegraph-ai/pull/47#discussion_r1627266889
########## .github/workflows/black.yml: ########## @@ -0,0 +1,17 @@ +name: "Black Code Formatter" + +on: + push: + branches: + - 'release-*' + pull_request: + +jobs: + lint: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + - uses: psf/black@stable Review Comment: > I think we have 2 approaches: > > 1. follow the rules and use the specific git hash (SHA1) of the action, for example `psf/black@3702ba224ecffbcec30af640c149f231d90aebdb` > 2. use `pip install & bash` as [`main`/.github/workflows/pylint.yml](https://github.com/apache/incubator-hugegraph-ai/blob/main/.github/workflows/pylint.yml?rgh-link-date=2024-06-05T05%3A26%3A15Z) did > > I prefer approach 1. > > Also, i found a ASF repo which may not obey the restriction but still confused how they did it. In [apache/shenyu@`master`/.github/workflows/e2e-k8s.yml](https://github.com/apache/shenyu/blob/master/.github/workflows/e2e-k8s.yml?rgh-link-date=2024-06-05T05%3A26%3A15Z)  Thanks for ur feedback~ U could try way1 first (This seems to be a new rule added this year, at least I didn't see it last year) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
