ChenZiHong-Gavin commented on code in PR #54: URL: https://github.com/apache/incubator-hugegraph-ai/pull/54#discussion_r1686027837
########## hugegraph-llm/src/hugegraph_llm/config/config.py: ########## @@ -20,8 +20,11 @@ from dataclasses import dataclass from typing import Literal, Optional -from pathlib import Path -from dotenv import dotenv_values +from dotenv import dotenv_values, set_key + +dirname = os.path.dirname +package_path = dirname(dirname(dirname(dirname(os.path.abspath(__file__))))) +env_path = os.path.join(package_path, ".env") Review Comment: There are some aspects that can be optimized in the future. - [ ] Add some configuration-related comments in the .env file - [ ] Rename `.env` filename to something related to hugegraph-llm - [ ] Unify the variables in the .env file and the variables in the Config class to be all uppercase - [ ] Differentiate between commonly used parameters and parameters that are secret keys - [ ] Give user a choice where to place their .env file -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
