VGalaxies commented on code in PR #2624:
URL:
https://github.com/apache/incubator-hugegraph/pull/2624#discussion_r1705572754
##########
hugegraph-store/hg-store-grpc/pom.xml:
##########
@@ -91,23 +91,23 @@
<pluginArtifact>
io.grpc:protoc-gen-grpc-java:${grpc.version}:exe:${os.detected.classifier}
</pluginArtifact>
- <!--默认值-->
+ <!--Default value-->
<protoSourceRoot>${project.basedir}/src/main/proto</protoSourceRoot>
- <!--默认值-->
+ <!--Default value-->
<!--<outputDirectory>${project.build.directory}/generated-sources/protobuf/java</outputDirectory>-->
<outputDirectory>${project.basedir}/src/main/java</outputDirectory>
-
<!--设置是否在生成java文件之前清空outputDirectory的文件，默认值为true，设置为false时也会覆盖同名文件-->
+ <!--Set whether to clear the files in outputDirectory
before generating java files, the default value is true, and it will also
override files with the same name when set to false-->
<clearOutputDirectory>false</clearOutputDirectory>
-
<!--更多配置信息可以查看https://www.xolstice.org/protobuf-maven-plugin/compile-mojo.html-->
+ <!--More configuration information can be found at
https://www.xolstice.org/protobuf-maven-plugin/compile-mojo.html-->
</configuration>
<executions>
<execution>
- <!--在执行mvn compile的时候会执行以下操作-->
+ <!--When executing mvn compile, the following
operations will be performed-->
<phase>generate-sources</phase>
<goals>
- <!--生成OuterClass类-->
+ <!--Generate OuterClass class-->
<goal>compile</goal>
- <!--生成Grpc类-->
+ <!--Generate Grpc classes-->
Review Comment:
```suggestion
<!-- Generate Grpc classes -->
```
##########
hugegraph-store/hg-store-grpc/pom.xml:
##########
@@ -91,23 +91,23 @@
<pluginArtifact>
io.grpc:protoc-gen-grpc-java:${grpc.version}:exe:${os.detected.classifier}
</pluginArtifact>
- <!--默认值-->
+ <!--Default value-->
<protoSourceRoot>${project.basedir}/src/main/proto</protoSourceRoot>
- <!--默认值-->
+ <!--Default value-->
<!--<outputDirectory>${project.build.directory}/generated-sources/protobuf/java</outputDirectory>-->
<outputDirectory>${project.basedir}/src/main/java</outputDirectory>
-
<!--设置是否在生成java文件之前清空outputDirectory的文件，默认值为true，设置为false时也会覆盖同名文件-->
+ <!--Set whether to clear the files in outputDirectory
before generating java files, the default value is true, and it will also
override files with the same name when set to false-->
<clearOutputDirectory>false</clearOutputDirectory>
-
<!--更多配置信息可以查看https://www.xolstice.org/protobuf-maven-plugin/compile-mojo.html-->
+ <!--More configuration information can be found at
https://www.xolstice.org/protobuf-maven-plugin/compile-mojo.html-->
</configuration>
<executions>
<execution>
- <!--在执行mvn compile的时候会执行以下操作-->
+ <!--When executing mvn compile, the following
operations will be performed-->
<phase>generate-sources</phase>
<goals>
- <!--生成OuterClass类-->
+ <!--Generate OuterClass class-->
Review Comment:
```suggestion
<!-- Generate OuterClass class -->
```
##########
hugegraph-store/hg-store-grpc/pom.xml:
##########
@@ -91,23 +91,23 @@
<pluginArtifact>
io.grpc:protoc-gen-grpc-java:${grpc.version}:exe:${os.detected.classifier}
</pluginArtifact>
- <!--默认值-->
+ <!--Default value-->
<protoSourceRoot>${project.basedir}/src/main/proto</protoSourceRoot>
- <!--默认值-->
+ <!--Default value-->
<!--<outputDirectory>${project.build.directory}/generated-sources/protobuf/java</outputDirectory>-->
<outputDirectory>${project.basedir}/src/main/java</outputDirectory>
-
<!--设置是否在生成java文件之前清空outputDirectory的文件，默认值为true，设置为false时也会覆盖同名文件-->
+ <!--Set whether to clear the files in outputDirectory
before generating java files, the default value is true, and it will also
override files with the same name when set to false-->
<clearOutputDirectory>false</clearOutputDirectory>
-
<!--更多配置信息可以查看https://www.xolstice.org/protobuf-maven-plugin/compile-mojo.html-->
+ <!--More configuration information can be found at
https://www.xolstice.org/protobuf-maven-plugin/compile-mojo.html-->
</configuration>
<executions>
<execution>
- <!--在执行mvn compile的时候会执行以下操作-->
+ <!--When executing mvn compile, the following
operations will be performed-->
Review Comment:
```suggestion
<!-- When executing mvn compile, the following
operations will be performed -->
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
