javeme commented on code in PR #2630:
URL:
https://github.com/apache/incubator-hugegraph/pull/2630#discussion_r1712619050
##########
hugegraph-store/hg-store-node/src/main/java/org/apache/hugegraph/store/node/grpc/HgStoreNodeService.java:
##########
@@ -140,14 +141,14 @@ void addRaftTask(byte methodId, String graphName, Integer
partitionId, Req req,
}
//
try {
- // 序列化，
+ // Serialization
final byte[] buffer = new byte[req.getSerializedSize() + 1];
final CodedOutputStream output =
CodedOutputStream.newInstance(buffer);
output.write(methodId);
req.writeTo(output);
output.checkNoSpaceLeft();
output.flush();
- // 传送给raft
+ //Add raft task
Review Comment:
expect a space "// Add ..."
##########
hugegraph-store/hg-store-node/src/main/java/org/apache/hugegraph/store/node/grpc/HgStoreNodeService.java:
##########
@@ -190,7 +191,8 @@ public boolean invoke(int partId, byte[] request,
RaftClosure response) throws
}
/**
- * 处理raft传送过来的数据
+ * Process the data sent by raft
+ *
Review Comment:
unused blank line
##########
.asf.yaml:
##########
@@ -28,7 +28,8 @@ github:
del_branch_on_merge: true
#labels:
enabled_merge_buttons:
- merge: false
+ # TODO: disable it after common merged
+ merge: true
Review Comment:
seems we don't need to change in this commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
