zyxxoo commented on code in PR #2615: URL: https://github.com/apache/incubator-hugegraph/pull/2615#discussion_r1716167372
########## hugegraph-it/hg-it-dist/pom.xml: ########## @@ -0,0 +1,78 @@ +<?xml version="1.0" encoding="UTF-8"?> Review Comment: the module name have been named for hugegraph-xxx, so the submodule perfect to keep consistent with the name, i mean, the 'hg' should replace with "hugegraph" ########## hugegraph-it/hg-it-dist/src/assembly/static/multi/pd/A/conf/application.yml.template: ########## Review Comment: I feel the template is a good idea, but i am confuse the 'application.yml', i think, the spec file should been generated by template with runtime params. we can use different params to generation different configuration cluster otherwise default ########## hugegraph-it/hg-it-dist/pom.xml: ########## @@ -0,0 +1,78 @@ +<?xml version="1.0" encoding="UTF-8"?> Review Comment: +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
