imbajin commented on code in PR #75:
URL:
https://github.com/apache/incubator-hugegraph-ai/pull/75#discussion_r1749250279
##########
hugegraph-llm/src/hugegraph_llm/operators/index_op/semantic_id_query.py:
##########
@@ -17,28 +17,38 @@
import os
-from typing import Dict, Any, Literal
+from copy import deepcopy
+from typing import Dict, Any, Literal, List, Tuple
+from pyhugegraph.client import PyHugeClient
from hugegraph_llm.config import resource_path, settings
from hugegraph_llm.indices.vector_index import VectorIndex
from hugegraph_llm.models.embeddings.base import BaseEmbedding
class SemanticIdQuery:
+ ID_QUERY_TEMPL = "g.V().hasId({vids_str})"
Review Comment:
```suggestion
ID_QUERY_TEMPL = "g.V({vids_str})"
```
no need to use extra `hasId/hasLabel` step (I'll enhance the gremlin in
graph_query logic in another PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
