VGalaxies commented on code in PR #2615: URL: https://github.com/apache/incubator-hugegraph/pull/2615#discussion_r1793734396
########## hugegraph-cluster-test/hugegraph-clustertest-minicluster/src/main/java/org/apache/hugegraph/ct/node/AbstractNodeWrapper.java: ########## @@ -0,0 +1,191 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hugegraph.ct.node; + +import static org.apache.hugegraph.ct.base.ClusterConstant.CT_PACKAGE_PATH; + +import java.io.File; +import java.io.FileNotFoundException; +import java.io.FileReader; +import java.io.IOException; +import java.nio.charset.StandardCharsets; +import java.nio.file.Files; +import java.nio.file.NoSuchFileException; +import java.nio.file.Path; +import java.nio.file.Paths; +import java.util.ArrayList; +import java.util.List; +import java.util.Scanner; +import java.util.concurrent.TimeUnit; +import java.util.stream.Stream; + +import org.apache.commons.io.FileUtils; +import org.apache.commons.io.file.PathUtils; +import org.apache.hugegraph.ct.base.ClusterConstant; +import org.apache.hugegraph.ct.base.EnvUtil; +import org.apache.hugegraph.ct.base.HGTestLogger; +import org.slf4j.Logger; + +import lombok.Getter; + +public abstract class AbstractNodeWrapper implements BaseNodeWrapper { + + protected final Logger LOG = HGTestLogger.NodeLOG; + + protected int clusterIndex; + @Getter + protected String workPath; + @Getter + protected String configPath; + protected Process instance; + protected int index; + protected List<String> fileNames; + protected String startLine; + + public AbstractNodeWrapper() { + this.clusterIndex = 1; + fileNames = new ArrayList<>(); + this.configPath = getNodePath(); + } + + public AbstractNodeWrapper(int clusterIndex, int index) { + this.clusterIndex = clusterIndex; + this.index = index; + fileNames = new ArrayList<>(); + this.configPath = getNodePath(); + } + + /** + * Node Dir should be created before changing Config + */ + public void createNodeDir(String destDir) { + try { + try { + if (!new File(destDir).exists()) { + FileUtils.createParentDirectories(new File(destDir)); + } + } catch (NoSuchFileException fileException) { + //Ignored + } + Path sourcePath = Paths.get(CT_PACKAGE_PATH); + // To avoid following symbolic links + try (Stream<Path> stream = Files.walk(sourcePath)) { + stream.forEach(source -> { + Path relativePath = sourcePath.relativize(source); + Path destination = Paths.get(destDir).resolve(relativePath); + if (fileNames.contains(relativePath.toString())) { + EnvUtil.copyFileToDestination(source, destination); + } + }); + } + } catch (IOException ioException) { + LOG.error("Got error copying files to node destination dir", ioException); + throw new AssertionError(); + } + } + + public void createLogDir() { + String logPath = getLogPath(); + try { + FileUtils.createParentDirectories(new File(logPath)); + } catch (IOException e) { + LOG.error("Create log dir failed", e); + throw new AssertionError(); + } + } + + public void deleteDir() { + try { + PathUtils.deleteDirectory(Paths.get(getNodePath())); + } catch (IOException ex) { + try { + TimeUnit.SECONDS.sleep(1); + } catch (InterruptedException e) { + Thread.currentThread().interrupt(); + LOG.error("Fail to delete node file", e); + throw new AssertionError("Delete node dir failed. " + e); + } + } + } + + /** + * @return (user.dir).id + */ + @Override + public String getNodePath() { + return CT_PACKAGE_PATH + getID() + File.separator; + } + + @Override + public String getLogPath() { + return getNodePath() + ClusterConstant.LOG + File.separator + getID() + "-start.log"; + } + + @Override + public void updateWorkPath(String workPath) { + this.workPath = workPath; + } + + @Override + public void updateConfigPath(String ConfigPath) { + this.configPath = ConfigPath; + } + + @Override + public boolean isStarted() { + try (Scanner sc = new Scanner(new FileReader(getLogPath()))) { + while (sc.hasNextLine()) { + String line = sc.nextLine(); + if (line.contains(startLine)) return true; + } + } catch (FileNotFoundException ignored) { + } + return false; + } + + public void stop() { + if (this.instance == null) { + return; + } + this.instance.destroy(); + try { + if (!this.instance.waitFor(20, TimeUnit.SECONDS)) { + this.instance.destroyForcibly().waitFor(10, TimeUnit.SECONDS); + } + } catch (InterruptedException e) { + Thread.currentThread().interrupt(); + LOG.error("Waiting node to shutdown error.", e); + } + deleteDir(); + } + + public boolean isAlive() { + return this.instance.isAlive(); + } + + protected ProcessBuilder runCmd(List<String> startCmd, File stdoutFile) throws IOException { + FileUtils.write(stdoutFile, + String.join(" ", startCmd) + "\n\n", StandardCharsets.UTF_8, true); Review Comment: use System.lineSeparator() instead of \n -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
