imbajin commented on code in PR #84:
URL: 
https://github.com/apache/incubator-hugegraph-ai/pull/84#discussion_r1794744140


##########
hugegraph-llm/src/hugegraph_llm/models/llms/openai.py:
##########
@@ -141,7 +140,7 @@ def num_tokens_from_string(self, string: str) -> int:
     def max_allowed_token_length(self) -> int:
         """Get max-allowed token length"""
         # TODO: list all models and their max tokens from api
-        return 2049
+        return 8192

Review Comment:
   > why increase to 8192?
   
   `2049` is outdated (in 2023y)
   
   BTW, this method is not used now (may remove it later)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to