JackyYangPassion commented on code in PR #2631:
URL:
https://github.com/apache/incubator-hugegraph/pull/2631#discussion_r1810981828
##########
hugegraph-store/hg-store-node/src/main/java/org/apache/hugegraph/store/node/metrics/JRaftMetrics.java:
##########
@@ -172,35 +168,33 @@ private static void registerHistogram(String group,
String name,
String baseName = PREFIX + "." + name.toLowerCase();
- HistogramWrapper wrapper = toWrapper(histogram);
-
- Gauge.builder(baseName + ".median", wrapper, (d) ->
d.getSnapshot().getMedian())
+ Gauge.builder(baseName + ".median", histogram, (d) ->
d.getSnapshot().getMedian())
Review Comment:
It turns out that the logic is to only request a snapshot after > 30
seconds,
which will cause the indicator to be empty. Therefore,
it is requested once every time the indicator is pulled.
The frequency is not high.
Online, it is usually pulled once every 15 seconds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
