Pengzna commented on code in PR #2649:
URL: 
https://github.com/apache/incubator-hugegraph/pull/2649#discussion_r1827612309


##########
hugegraph-commons/hugegraph-dist/scripts/dependency/known-dependencies.txt:
##########


Review Comment:
   > > why change this file?
   > 
   > maybe influenced by `Fury` dependencies🤔?
   
   Yes, and I ran wrong `regenerate_known_dependencies.sh` which is in 
hugegraph-dist/scripts/dependency, resulting in a duplicate 
`known-dependencies.txt` under hugegraph-dist/scripts/dependency.
   
   Actually, only `regenerate_known_dependencies.sh` in 
/install-dist/scripts/dependency is enough and correct. 
`regenerate_known_dependencies.sh` in hugegraph-dist/scripts/dependency seems 
useless and may cause misunderstanding for programmers.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to