returnToInnocence commented on code in PR #122: URL: https://github.com/apache/incubator-hugegraph-ai/pull/122#discussion_r1872523513
########## hugegraph-llm/src/hugegraph_llm/config/__init__.py: ########## @@ -16,15 +16,21 @@ # under the License. -__all__ = ["settings", "resource_path"] +__all__ = ["huge_settings", "admin_settings", "llm_settings", "resource_path"] import os -from .config import Config, PromptConfig -settings = Config() Review Comment: There is a small issue here, which is that if the settings are changed to multiple subcategories of settings, the corresponding functionality for other application settings also needs to be adjusted accordingly. Otherwise, the issue shown in the image below will occur.  The specific code that causes the issue is shown in the image below.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
