imbajin commented on code in PR #131:
URL:
https://github.com/apache/incubator-hugegraph-ai/pull/131#discussion_r1875601299
##########
hugegraph-ml/src/hugegraph_ml/models/bgrl.py:
##########
@@ -252,4 +252,5 @@ def get_graph_drop_transform(drop_edge_p, feat_mask_p):
if feat_mask_p > 0.0:
transforms.append(FeatMask(feat_mask_p, node_feat_names=["feat"]))
- return Compose(transforms)
\ No newline at end of file
+ return Compose(transforms)
+
Review Comment:
lack empty line here?
##########
hugegraph-ml/src/hugegraph_ml/models/cluster_gcn.py:
##########
@@ -36,9 +35,9 @@ class SAGE(nn.Module):
def __init__(self, in_feats, n_hidden, n_classes):
super().__init__()
self.layers = nn.ModuleList()
- self.layers.append(dglnn.SAGEConv(in_feats, n_hidden, "mean"))
- self.layers.append(dglnn.SAGEConv(n_hidden, n_hidden, "mean"))
- self.layers.append(dglnn.SAGEConv(n_hidden, n_classes, "mean"))
+ self.layers.append(dglnn.SAGEConv(in_feats, n_hidden, "mean")) #
pylint: disable=E1101
+ self.layers.append(dglnn.SAGEConv(n_hidden, n_hidden, "mean")) #
pylint: disable=E1101
+ self.layers.append(dglnn.SAGEConv(n_hidden, n_classes, "mean")) #
pylint: disable=E1101
Review Comment:
maybe change it to the `method` scope?
##########
style/code_format_and_analysis.sh:
##########
@@ -53,7 +53,5 @@ if [ "$PYLINT" = true ] ; then
echo "[pylint] Start code analysis and check,
we need to manually fix all the warnings mentioned below before commit! "
export
PYTHONPATH=${ROOT_DIR}/hugegraph-llm/src:${ROOT_DIR}/hugegraph-python-client/src:${ROOT_DIR}/hugegraph-ml/src
- pylint --rcfile=${ROOT_DIR}/style/pylint.conf ${ROOT_DIR}/hugegraph-llm
- pylint --rcfile=${ROOT_DIR}/style/pylint.conf ${ROOT_DIR}/hugegraph-ml
- pylint --rcfile=${ROOT_DIR}/style/pylint.conf --disable C0103
${ROOT_DIR}/hugegraph-python-client
+ pylint --rcfile=${ROOT_DIR}/style/pylint.conf ${ROOT_DIR}/hugegraph-llm
${ROOT_DIR}/hugegraph-ml ${ROOT_DIR}/hugegraph-python-client
Review Comment:
@simon824 root reason for "CI not work as expect" before 😢
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
